[Fix]CallViewModel ending outgoing group call when one of the participants rejects #901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Public Interface🚀 No changes affecting the public interface. |
Collaborator
SDK Size
|
martinmitrevski approved these changes Jul 24, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where outgoing group calls would incorrectly end for all participants when just one participant rejects the call. The fix ensures that when calls are created externally (with empty members array), the CallViewModel properly observes call member updates to maintain accurate participant counts.
Key changes:
- Added observation of
CallState.membersfor externally created outgoing calls - Enhanced test infrastructure with MockDefaultAPI support
- Improved call rejection logic with descriptive reason messages
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| StreamVideoSwiftUI/CallViewModel.swift | Added member observation logic to fix premature call ending |
| StreamVideoTests/Mock/MockDefaultAPI.swift | Added getOrCreateCall mock method for test infrastructure |
| StreamVideoTests/Mock/MockCall.swift | Enhanced create method with proper error handling |
| StreamVideoSwiftUITests/CallViewModel_Tests.swift | Added comprehensive test for rejection scenario |
| StreamVideo.xcodeproj/project.pbxproj | Added MockDefaultAPI to test target sources |
Comments suppressed due to low confidence (2)
Sources/StreamVideoSwiftUI/CallViewModel.swift:70
- [nitpick] The variable name
callMembersUpdatesis not descriptive enough. Consider renaming it tooutgoingCallMembersUpdatesto clearly indicate it's specifically for tracking outgoing call member updates.
callMembersUpdates = call? StreamVideoSwiftUITests/CallViewModel_Tests.swift:221
- [nitpick] The test function name is very long and could be more concise. Consider renaming to
test_outgoingCall_oneParticipantRejects_callContinues()for better readability.
func test_outgoingCall_callCreatedPriorToStarting_rejectedEventFromOneParticipantCallRemainsOngoing() async throws { 
ipavlidakis force-pushed the fix/callviewmodel-ending-call-when-one-other-participant-rejects-call branch from 52d4dc3 to b4d37b6 Compare Public Interface🚀 No changes affecting the public interface. |
ipavlidakis deleted the fix/callviewmodel-ending-call-when-one-other-participant-rejects-call branch Public Interface🚀 No changes affecting the public interface. |
Closed
|
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves https://linear.app/stream/issue/IOS-1031/blinkios-ending-outgoing-group-call-when-one-of-the-participants
📝 Summary
In cases where the call is being created on the backend and the iOS device relies on it to set the call data correctly, by calling
CallViewModel.startCallwith an emptymembersandring = truearray then if the call is rejected by one of the participants then iOS mistakenly will end the call for everyone.🛠 Implementation
The CallViewModel now observes the
CallState.memberswhen itscallingState = .outgoingandoutgoingCallMembers.isEmpty.🧪 Manual Testing Notes
☑️ Contributor Checklist