- Notifications
You must be signed in to change notification settings - Fork 4
JSR readiness #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
JSR readiness #165
Conversation
* fix(jsr_readiness): lint/fmt * fix(jsr_readiness): lint/fmt * fix(jsr_readiness): rename _test to .test * fix(jsr_readiness): rename _test to .test * fix(jsr_readiness): remove editorconfig from published files * fix(jsr_readiness): remove editorconfig from published files * fix(jsr_readiness): remove .test files from publishing * fix(jsr_readiness): remove tasks job options * fix(jsr_readiness): remove npm build in favor of jsr, update deno t oreflect this change * fix(jsr_readiness): rename ci and simplify ci files * fix(jsr_readiness): remove unused cli import * fix(jsr_readiness): update deno step to use denoland action * fix(jsr_readiness): remove import map and use deno strat for devImports, and still use jsr * fix(jsr_readiness): reorder command * fix(jsr_readiness): use parallel option for tests, add better dir for coverage * fix(jsr_readiness): remove unused options from deno json * fix(jsr_readiness): move compilerOptions * fix(jsr_readiness): add no lock * fix(jsr_readiness): add root dir location * fix(jsr_readiness): add root dir location * fix(jsr_readiness): use stright strings for tasks * fix(jsr_readiness): fmt * fix(jsr_readiness): ffix imprts back to using a map * fix(jsr_readiness): comments
| @ms1111 I see you're in the repo lately. Could I get your thoughts here on JSR? IF we keep distributing to NPM could we also add JSR - @ChrisDufourMB followed up about it and I hear MB devs didn't want to move away from NPM - which I get, but if we keep NPM publishing there is no need to say no to also publishing on JSR (a superset of NPM) Thanks in advance. |
| I took a read through the JSR docs today and I liked that they started out with OAuth based publishing (trusted publishing). I also like that you can register a scope and delegate it to a few GitHub users. Let me ask some questions on my end to see if there would be any problems with publishing to JSR. I might need a week or two. |
| | ||
| # When we decide to publish to JSR we'll need to rename the | ||
| # module to @gamebridge/serialize or something similar | ||
| # because `_` is not allowed in module names. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that's interesting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeaa! Man it was a gut punch to hear that
| run: deno task build | ||
| - name: Publish module to jsr.io | ||
| run: deno publish --dry-run | ||
| if: matrix.os == 'ubuntu-latest' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we publish to both jsr and npm? Is that a typical thing to do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is pretty normal to publish to both. NPM adoption is important, and JSR is described as a superset of NPM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although in my eagerness, I removed NPM publish, I can easily put it back
Description
TBA - This PR is part of a larger discussion about how and where we publish this repo.
https://jsr.io/