Skip to content

Conversation

@stof
Copy link
Member

@stof stof commented Jun 16, 2014

  • add testing on HHVM and PHP 5.6
  • test the non-latest versions of Symfony only once instead of doing it for all PHP versions, thus reducing the matrix
  • build only the master branch and the release branches to avoid extra builds when using the main repo for feature branches
  • let composer use individual components and bundles for the normal resolution of Symfony
- add testing on HHVM and PHP 5.6 - test the non-latest versions of Symfony only once instead of doing it for all PHP versions, thus reducing the matrix - build only the master branch and the release branches to avoid extra builds when using the main repo for feature branches - let composer use individual components and bundles for the normal resolution of Symfony
@stof
Copy link
Member Author

stof commented Jun 16, 2014

@dbu Scrutinizer should also be improved to run inspections for pushes only on master and not on feature branches, but I cannot do it as I'm not an admin on the repo on Scrutinizer

ddeboer added a commit that referenced this pull request Jun 16, 2014
@ddeboer ddeboer merged commit 9693d74 into master Jun 16, 2014
@ddeboer ddeboer deleted the travis_improvements branch June 16, 2014 10:51
@ddeboer
Copy link
Member

ddeboer commented Jun 16, 2014

@stof What’s wrong with running Scrutinizer on feature branches, too? It gives valuable information about a PR’s code coverage, for instance.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess we should additionally do symfony 2.5.* now that it is out. dev-master is 2.6.* now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.5 is tested by the normal build as Composer will select the latest release

@ddeboer
Copy link
Member

ddeboer commented Jun 16, 2014

@dbu Seems I was a bit too quick with merging this one. I’ll apply your suggestions to master.

@stof
Copy link
Member Author

stof commented Jun 16, 2014

@ddeboer it already builds PRs. The issue is that currently, it builds both the feature branch and the PR. given that it can do only 1 build at a time, it slows things down without any value.

@dbu
Copy link
Contributor

dbu commented Jun 16, 2014

cool, thanks a lot!

@ddeboer
Copy link
Member

ddeboer commented Jun 16, 2014

@stof Okay, changed the Scrutinizer config to only track pushes on master (+ PRs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants