Applied Fabpot php-cs-fixer to all code #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
mmoreram commented Jun 16, 2014
mmoreram commented - Also fixed a non PSR-0 namespace in Tests folder
Member
| Can you rebase this quickly ? It conflicts because your PR about license headers included a few space changes and this PR adds the EOL at end of files for the same files |
* All headers follow FOS format, defined in FriendsOfSymfony/friendsofsymfony.github.io#14 (comment)
Contributor Author
| Rebased. |
ddeboer added a commit that referenced this pull request Jun 16, 2014
Applied Fabpot php-cs-fixer to all code
Member
| Thanks, @mmoreram! |
Contributor
| well done, thanks a lot. this is also good preparation for the phpdoc update PR. i suggest you just add the comments where you understand what its about and can describe things and list the class names that miss more doc in the PR, then i can add that into the code and merge both together. |
Contributor Author
| Yes, I am working on it right now :) appreciate this appreciation ^^ |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.