- Notifications
You must be signed in to change notification settings - Fork 84
Add invalidate all command #544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add invalidate all command #544
Conversation
dbu left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no such method on the manager. what we do have is clearCache to clear the cache for all domains. only the symfony http cache implements clear cache.
it would make sense to have a command for clear cache. we could also make the varnish client implement clear and internally send a BAN for .*
| @dbu should we implement the |
5d78d56 to 22ea027 Compare
dbu left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we implement the ClearCapable Interface into the Varnish Implementation and doing there the BAN with .*?
i would prefer to fallback to banning in the clear command.
22ea027 to eb27165 Compare
dbu left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, looks good to me 👍
i have a few wording and capitalization suggestions.
can you please add an entry to the changelog to mention the new command?
| @dbu seems like CacheInvalidator::CLEAR is only available since http-cache 2.6 should we increase the require http-cache version or do you prefer keep the min requirement and find another way? |
cc322e2 to f13d4cd Compare | thanks a lot! maybe it would make sense to do the build fix PR in a separate branch to keep it apart from the new command. would you mind splitting it out? |
| please rebase this now that the CI setup is fixed in master |
Co-authored-by: David Buchmann <david@liip.ch>
f13d4cd to af391d6 Compare | @dbu rebased and suggested changes done! |
dbu left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, looks great!
one last thing: can you please add a note to the changelog (for next minor version) under the Added section?
| @dbu done! |
| thanks a lot! tagged a release: https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/releases/tag/2.9.0 |
| @dbu Awesome! Thank you for your fast reviews :) |
It would be great to have also a command to invalidate the whole cache to call it in a deployment script.