Skip to content

Fix InvalidConfigurationException message after TagCapable support in logout_handler #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 29, 2019
Merged

Fix InvalidConfigurationException message after TagCapable support in logout_handler #528

merged 3 commits into from
Jul 29, 2019

Conversation

@andrerom
Copy link
Contributor

@andrerom andrerom commented Jul 29, 2019

André R and others added 2 commits July 29, 2019 15:48
dbu
dbu approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, specific examples help 👍
@dbu
Copy link
Contributor

dbu commented Jul 29, 2019

can you please adjust the test that assumes "ban" in the exception message as well?
@andrerom andrerom force-pushed the fix_logout_handler_InvalidConfigurationException branch from c930bde to 6389747 Compare July 29, 2019 16:23
@andrerom
Copy link
Contributor Author

andrerom commented Jul 29, 2019

@dbu Done, remaining failure is irrelevant (tried downgrading to trusty, but same error there):

0.36s$ if [[ "$DOCCHECK" = true ]]; then make -C Resources/doc SPHINXOPTS='-nW' html; fi make: Entering directory `/home/travis/build/FriendsOfSymfony/FOSHttpCacheBundle/Resources/doc' sphinx-build -b html -d _build/doctrees -nW . _build/html Making output directory... Running Sphinx v1.2.2 Exception occurred: File "/usr/lib/python2.7/dist-packages/sphinx/locale/__init__.py", line 191, in _ return translators['sphinx'].ugettext(message) KeyError: 'sphinx' The full traceback has been saved in /tmp/sphinx-err-rX7zww.log, if you want to report the issue to the developers.
@dbu
Copy link
Contributor

dbu commented Jul 29, 2019

thanks!
re the sphinx failure: i tried to fix it in FOSHttpCache a while ago but did not find a solution: FriendsOfSymfony/FOSHttpCache#450
@dbu dbu merged commit aa9daf9 into FriendsOfSymfony:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@andrerom @dbu