do not leak the Symfony-Session-NoAutoCacheControl header when the Symfony session system is not enabled. #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…mfony session system is not enabled.
dbu commented Mar 12, 2019
| $response->setVary($this->options['user_identifier_headers']); | ||
| $response->setPublic(); | ||
| if (4 <= Kernel::MAJOR_VERSION && 1 <= Kernel::MINOR_VERSION) { | ||
| if ($this->hasSessionListener && version_compare('4.1', Kernel::VERSION, '<=')) { |
Contributor Author
There was a problem hiding this comment.
the old code would have been broken with symfony 5.0.
<= comparator seems to work with all php versions: https://3v4l.org/GCltV
There was a problem hiding this comment.
The old code failed with 5.0, but works with 5.1: https://3v4l.org/PtroA
Contributor Author
There was a problem hiding this comment.
exactly. thanks for looking at this, reminds me that i should merge it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fix #512