Invalidate context after switch user #510
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
onEXHovia force-pushed the switch-user branch from 73e2540 to 2a0a7f2 Compare 
dbu approved these changes Dec 20, 2018
Contributor
dbu left a comment
dbu left a comment There was a problem hiding this comment.
great job, thanks!
i think we don't need this in the documentation, but should have a phpdoc on the listener class. and can you please add an entry to the changlog (i'd put it as "fix" because we consider it a fix)
| use Symfony\Component\Security\Http\Event\SwitchUserEvent; | ||
| use Symfony\Component\Security\Http\SecurityEvents; | ||
| | ||
| class SwitchUserListener implements EventSubscriberInterface |
Contributor
There was a problem hiding this comment.
can you add a phpdoc with the explanation why we do this? (basically the TLDR of our discussion in the issue you reported)
Contributor
| i added the changelog and phpdoc and merged manually. thanks again for the contribution! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #506
I added some tests, but not sure that fully covered this feature. Let me know if need to add something. Thanks!