Fix requirements sphinxcontrib-phpdomain and use newest rtd theme #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
alexander-schranz force-pushed the patch-1 branch from d8c4780 to 2168ab6 Compare alexander-schranz changed the title 
Contributor Author
| @dbu I can't reproduce the problem locally so I now try to activate the phpblock from sensio and import the correct phpdomain package. Also I use the rtd theme also in the ci. |
Contributor
| thanks for these cleanups. they all make sense, so either way its a win to merge them. lets see what happens now. |
Contributor
| yay, much colors, such wow! thanks again. i will apply these fixes to the FOSHttpCache library repository now to also fix things there. |
dbu added a commit to FriendsOfSymfony/FOSHttpCache that referenced this pull request Oct 23, 2018
dbu added a commit to FriendsOfSymfony/FOSHttpCache that referenced this pull request Oct 23, 2018
Contributor
| FriendsOfSymfony/FOSHttpCache#433 i noticed that the library handles the rtd theme a bit differently, will align the bundle with how the library does: #498 |
Contributor Author
| @dbu looks good for me |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
#495 did not fix the code highlighting
sphinxcontrib-phpdomainas correct requirementssphinx_rtd_themeand use it in the ciphpdocfrom sensio