Skip to content

make tag annotations optional inside tags to allow using them without FrameworkExtraBundle #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2018
Merged

make tag annotations optional inside tags to allow using them without FrameworkExtraBundle #492

merged 1 commit into from
Oct 23, 2018

Conversation

@dbu
Copy link
Contributor

@dbu dbu commented Oct 16, 2018

fix #489
@dbu
Copy link
Contributor Author

dbu commented Oct 16, 2018

i don't know how contao exactly works, but be aware that if users write their own controllers, they might rely on tag annotations and need to be aware of the change so that they overwrite the configuration and add the framework extra bundle themselves.
@dbu dbu force-pushed the framework-extra-bundle-dep branch from 9304418 to ca1ed9b Compare October 17, 2018 06:09
@dbu
Copy link
Contributor Author

dbu commented Oct 17, 2018

@Toflar may i ask you to review this one and check if it works as intended in contao?
@Toflar
Copy link
Contributor

Toflar commented Oct 17, 2018

That looks good, yes! Just the false case is not covered in tests now :)
@dbu dbu force-pushed the framework-extra-bundle-dep branch from ca1ed9b to 9bbf553 Compare October 23, 2018 13:19
@dbu
Copy link
Contributor Author

dbu commented Oct 23, 2018

right, added the test
@dbu dbu merged commit 74d761e into master Oct 23, 2018
@dbu dbu deleted the framework-extra-bundle-dep branch October 23, 2018 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@dbu @Toflar