Skip to content

Conversation

@dbu
Copy link
Contributor

@dbu dbu commented Jan 26, 2014

Lets see if this all works out.

.travis.yml Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the end-to-end functional tests are in FOSHttpCache. do we want end-to-end tests with the listeners too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, let's not do that. Integration testing against Varnish is now in the library, so having it in the bundle too only makes it harder to maintain.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, will remove that part. if someday we need functional tests in the
bundle, we can always add it with what we have in the library.

@ddeboer
Copy link
Member

ddeboer commented Jan 27, 2014

Not sure yet whether the bundle's CacheManager should extend the library's CacheManager. In fact, there's a difference:

  • the bundle's CacheManager really manages stuff that has to do with caching, so it's an appropriate name
  • but the library's CacheManager (after the split) doesn't do much managing, anymore (except perhaps the get|setTagsHeader(). It's really more of an Invalidator.

Perhaps the CacheManager should contain an Invalidator instead of extending a base CacheManager?

@dbu
Copy link
Contributor Author

dbu commented Jan 27, 2014

i did a PR to rename from manager to invalidator in the library, makes sense to me. for the bundle i would opt to keep things this way, manager extending the invalidator from the lib. having just the tagging mechanism without the invalidation possibilities seems really pointless. one might use the bundle without a cache manager at all, to just define caching rules. so the manager service should be optional.

if one day we add support for invalidating symfony cache layer, we can drop the hard requirement on guzzle.

@dbu
Copy link
Contributor Author

dbu commented Jan 31, 2014

okay, updated again and created #33 for my remaining question. imho this can now be merged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems not to work on php 5.3 on travis. it works fine on my machine. strange, any ideas? should we convert to mockery?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, seems to be that framework-bundle 2.3 does not require security yet. i am on it.

@ddeboer
Copy link
Member

ddeboer commented Jan 31, 2014

Yes, let's squash and merge this when tests succeed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because of changing minimum-stability to be able to test with symfony 2.5, i discovered that mockery is preparing a BC break in their master. i guess its about mockery/mockery#144 (they did not release anything in the last 10 months :-( ). the UPGRADE.md does not mention the break or explain how to handle it. lets freeze on 0.8 for now.

dbu added a commit that referenced this pull request Jan 31, 2014
removing FOSHttpCache parts and adjusting namespaces. cleaning up doc
@dbu dbu merged commit b024bb9 into master Jan 31, 2014
@dbu dbu deleted the split-library branch January 31, 2014 14:39
@dbu
Copy link
Contributor Author

dbu commented Jan 31, 2014

yay, all green!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants