- Notifications
You must be signed in to change notification settings - Fork 84
removing FOSHttpCache parts and adjusting namespaces. cleaning up doc #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.travis.yml Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the end-to-end functional tests are in FOSHttpCache. do we want end-to-end tests with the listeners too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, let's not do that. Integration testing against Varnish is now in the library, so having it in the bundle too only makes it harder to maintain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, will remove that part. if someday we need functional tests in the
bundle, we can always add it with what we have in the library.
| Not sure yet whether the bundle's CacheManager should extend the library's CacheManager. In fact, there's a difference:
Perhaps the CacheManager should contain an Invalidator instead of extending a base CacheManager? |
| i did a PR to rename from manager to invalidator in the library, makes sense to me. for the bundle i would opt to keep things this way, manager extending the invalidator from the lib. having just the tagging mechanism without the invalidation possibilities seems really pointless. one might use the bundle without a cache manager at all, to just define caching rules. so the manager service should be optional. if one day we add support for invalidating symfony cache layer, we can drop the hard requirement on guzzle. |
| okay, updated again and created #33 for my remaining question. imho this can now be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems not to work on php 5.3 on travis. it works fine on my machine. strange, any ideas? should we convert to mockery?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, seems to be that framework-bundle 2.3 does not require security yet. i am on it.
| Yes, let's squash and merge this when tests succeed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because of changing minimum-stability to be able to test with symfony 2.5, i discovered that mockery is preparing a BC break in their master. i guess its about mockery/mockery#144 (they did not release anything in the last 10 months :-( ). the UPGRADE.md does not mention the break or explain how to handle it. lets freeze on 0.8 for now.
removing FOSHttpCache parts and adjusting namespaces. cleaning up doc
| yay, all green! |
Lets see if this all works out.