Skip to content

Added a case for banning user context hash object. Partial fix for #482 #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Added a case for banning user context hash object. Partial fix for #482 #427

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions resources/config/varnish/fos_ban.vcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ sub fos_ban_recv {
// the left side is the response header, the right side the invalidation header
+ " && obj.http.X-Cache-Tags ~ " + req.http.X-Cache-Tags
);
} elseif(req.http.Cookie) {
ban("obj.http.X-Host ~ " + req.http.X-Host
+ " && obj.http.X-Url ~ " + req.http.X-Url
+ " && obj.http.content-type ~ " + req.http.X-Content-Type
+ " && obj.http.Cookie ~ " + req.http.Cookie
);
} else {
ban("obj.http.X-Host ~ " + req.http.X-Host
+ " && obj.http.X-Url ~ " + req.http.X-Url
Expand All @@ -37,6 +43,9 @@ sub fos_ban_backend_response {
# Set ban-lurker friendly custom headers
set beresp.http.X-Url = bereq.url;
set beresp.http.X-Host = bereq.http.host;
if (bereq.http.accept ~ "application/vnd.fos.user-context-hash") {
set beresp.http.Cookie = ";" + bereq.http.Cookie;
}
}

sub fos_ban_deliver {
Expand All @@ -46,6 +55,7 @@ sub fos_ban_deliver {
# Remove ban-lurker friendly custom headers when delivering to client
unset resp.http.X-Url;
unset resp.http.X-Host;
unset resp.http.Cookie;

# Unset the tagged cache headers
unset resp.http.X-Cache-Tags;
Expand Down