Skip to content

Conversation

@lepiaf
Copy link

@lepiaf lepiaf commented Nov 20, 2014

Hello,

I have to override createRequest to pass an option to the $request : $request->getQuery()->useUrlEncode(false);

I did overload on createRequest in VarnishProxy, but in AbstractProxy the request is override by sendRequest and the option is gone.

Thierry

@dbu
Copy link
Contributor

dbu commented Nov 21, 2014

i see what you want to do. seems sane to me. @ddeboer wdyt? should we bump the minor version - the test shows that there could be edge cases with surprises...

the test fail on travis is coming because the Varnish class overwrites the createRequest method to do some validation and there was an incorrect mock request that lost the method. i fix this in #137

@ddeboer
Copy link
Member

ddeboer commented Nov 21, 2014

This PR makes sure all requests to the proxy are built in the same way (and can therefore be overridden), so I agree. And yes, it warrants a minor version bump; you can’t have enough of those. 😉

Let's first merge #137 and then see if the tests succeed here.

ddeboer added a commit that referenced this pull request Nov 21, 2014
use current class createRequest instead of client
@ddeboer ddeboer merged commit 480615b into FriendsOfSymfony:master Nov 21, 2014
@ddeboer
Copy link
Member

ddeboer commented Nov 21, 2014

Merged and tagged 1.1.1. Thanks, @lepiaf!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants