fix accept header handling when client sends no accept header #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| The things you find when using code in production. :) Looks fine to me, but maybe add a test to ensure the correct behaviour? |
CHANGELOG.md Outdated
Member
There was a problem hiding this comment.
This should be changed to 1.1.2 now.
dbu force-pushed the fix-accept-header-handling branch from d658e80 to bbdd2fe Compare Contributor Author
| There we go, added a test (i also tried breaking things and it actually works :-) test fails without the vcl fixes) |
Contributor Author
There was a problem hiding this comment.
this is just a weird hack to not need more backend php files for the testing - the permutations would lead to many files.
Member
| PR looks fine to me. Let’s add the |
dbu force-pushed the fix-accept-header-handling branch from bbdd2fe to e894523 Compare ddeboer added a commit that referenced this pull request Nov 21, 2014
fix accept header handling when client sends no accept header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
we discovered this in a rest api where a client was sending requests without accept headers. this is not good practice but allowed by the http spec. if the backend only has one type of answer, it usually works out.
we accidentally converted this into an existing Accept header with empty value, which by the HTTP spec means the client is not accepting any format. leading a spec-adherent backend with no other option than raising a 4xx error.