[WIP] testing guzzle exceptions

[dbu]

i tried to trigger the guzzle exception handling we have. code coverage indicates we never see a RequestException in the handleException method. however, i was not able to ever produce that exception. any ideas what we could do? or can we simply drop that excpetion? or am i just confused?

nevermind the code in this PR, i have left all kind of debugging and experimenting stuff lying around.

[ddeboer]

Guzzle will throw a RequestException for 50*s, for instance. So if Varnish is configured to throw a 501 Not Implemented when receiving a BAN (maybe if you want to make clear that the proxy is not configured for banning), this will be come a RequestException. Does that help?

[dbu]

not sure if this really is a good idea, but saw that this is the base class. the ClientInterface does not explain what exceptions to expect.

[dbu]

okay, i think this is now good. except for #109 and a phpunit bug with showing interfaces as covered the coverage now looks really good.

[ddeboer]

Yeah, look at that coverage! :)

Do we need to do anything to get the PHPUnit coverage right, like switching /* to /**?

[stof]

you should not die

[dbu]

ups. leftover debug code that is never triggered when the implementation behaves as expected. fixed in 8a84260