Skip to content

Conversation

NoMaY-jp
Copy link
Contributor

Description

This PR fixes broken #warning message in ARM_CMx_MPU/portmacro.h which was broken between 10.3.1 and 10.4.0.

Before this PR
#warning "~~~. https: /*www.FreeRTOS.org/FreeRTOS-V10.3.x.html" */

After this PR
#warning "~~~. https://www.FreeRTOS.org/FreeRTOS-V10.3.x.html"

The souce code were as follows:

#warning message in 10.4.0

#warning "configENFORCE_SYSTEM_CALLS_FROM_KERNEL_ONLY is not defined. We recommend defining it to 1 in FreeRTOSConfig.h for better security. https: /*www.FreeRTOS.org/FreeRTOS-V10.3.x.html" */

#warning "configENFORCE_SYSTEM_CALLS_FROM_KERNEL_ONLY is not defined. We recommend defining it to 1 in FreeRTOSConfig.h for better security. https: /*www.FreeRTOS.org/FreeRTOS-V10.3.x.html" */

#warning "configENFORCE_SYSTEM_CALLS_FROM_KERNEL_ONLY is not defined. We recommend defining it to 1 in FreeRTOSConfig.h for better security. https: /*www.FreeRTOS.org/FreeRTOS-V10.3.x.html" */

#warning "configENFORCE_SYSTEM_CALLS_FROM_KERNEL_ONLY is not defined. We recommend defining it to 1 in FreeRTOSConfig.h for better security. https: /*www.FreeRTOS.org/FreeRTOS-V10.3.x.html" */

#warning message in 10.3.1

#warning "configENFORCE_SYSTEM_CALLS_FROM_KERNEL_ONLY is not defined. We recommend defining it to 1 in FreeRTOSConfig.h for better security. https://www.freertos.org/FreeRTOS-V10.3.x.html"

#warning "configENFORCE_SYSTEM_CALLS_FROM_KERNEL_ONLY is not defined. We recommend defining it to 1 in FreeRTOSConfig.h for better security. https://www.freertos.org/FreeRTOS-V10.3.x.html"

#warning "configENFORCE_SYSTEM_CALLS_FROM_KERNEL_ONLY is not defined. We recommend defining it to 1 in FreeRTOSConfig.h for better security. https://www.freertos.org/FreeRTOS-V10.3.x.html"

#warning "configENFORCE_SYSTEM_CALLS_FROM_KERNEL_ONLY is not defined. We recommend defining it to 1 in FreeRTOSConfig.h for better security. https://www.freertos.org/FreeRTOS-V10.3.x.html"

Test Steps

None (I think that checking by compiling RTOSDemo programs which use these portable layers is better than nothing to do but I don't have such compilers. And I think that checking by review will be enough for this PR.)

Related Issue

[BUG] Uncrustify(?) breaks #warning in ARM_CMx_MPU/portmacro.h #167

@cobusve cobusve merged commit 2428081 into FreeRTOS:master Sep 15, 2020
@NoMaY-jp NoMaY-jp deleted the Fix_broken_warning_message_in_portmacro_h branch February 23, 2021 04:52
@NoMaY-jp NoMaY-jp restored the Fix_broken_warning_message_in_portmacro_h branch February 23, 2021 04:53
@NoMaY-jp NoMaY-jp deleted the Fix_broken_warning_message_in_portmacro_h branch February 23, 2021 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants