Remove Unused Code and Preprocessor Directives in RP2040 Port

[PascalReich]

Remove Unused Code and Preprocessor Directives in RP2040 Port

Description

• Ever since the variables to enable/disable SMP were standardized to "configNUMBER_OF_CORES" in RP2040 updates/fixes from github.com/raspberrypi/FreeRTOS-Kernel #1193, there have been some code regions that use duplicate or inconsistent preprocessor conditions
• Consider the following example

#if ( configNUMBER_OF_CORES == 1 ) // some code #else // implicitly configNUMBER_OF_CORES != 1  #if ( configNUMBER_OF_CORES != 1 ) // always selected #else // never selected (redundant/unnecessary) #endif #endif

• In this case, the entire second set of preprocessor directives can be removed, with the always selected code staying and the redundant code also being deleted.
• Most of this was done for inline assembly code, in total for 4 instances total.
• Open to any feedback

Test Steps

N/A

Checklist:

• I have run limited compilation tests locally, tbh unsure of how to run the full test suite but happy to do so.
• I have tested my changes. No regression in existing tests.
• I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

None

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[aggarg]

@kilograham Would you please take a quick look? Thanks.