Remove duplicate pop from MPU Wrappers ASM Files #1008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…able/GCC/ARM_CM23/mpu_wrappers_v2_asm.c
…able/GCC/ARM_CM23_NTZ/mpu_wrappers_v2_asm.c
…able/GCC/ARM_CM33/mpu_wrappers_v2_asm.c
…able/GCC/ARM_CM33_NTZ/mpu_wrappers_v2_asm.c
…able/IAR/ARM_CM23/mpu_wrappers_v2_asm.S
…able/IAR/ARM_CM23_NTZ/mpu_wrappers_v2_asm.S
…able/IAR/ARM_CM33/mpu_wrappers_v2_asm.S
…able/IAR/ARM_CM33_NTZ/mpu_wrappers_v2_asm.S
… duplicate pop instruction in mpu_wrappers_v2_asm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## main #1008 +/- ## ======================================= Coverage 93.00% 93.00% ======================================= Files 6 6 Lines 3200 3200 Branches 879 879 ======================================= Hits 2976 2976 Misses 111 111 Partials 113 113
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kar-rahul-aws approved these changes Mar 13, 2024
aggarg approved these changes Mar 18, 2024
|
laroche pushed a commit to laroche/FreeRTOS-Kernel that referenced this pull request Apr 18, 2024
laroche pushed a commit to laroche/FreeRTOS-Kernel that referenced this pull request Apr 18, 2024
….(32bit/64bit) (FreeRTOS#1199) * [WIN32-MingW Demo] Add tick type width definition based on compiler type.(32bit/64bit) 32bit TickType_t is used if compiler is MinGW32. 64bit TickType_t is used if compiler is MinGW64. Reason of change: Before this change, 32bit TickType_t is always used in MinGW demo. It is inefficient for 64bit compiler. In addition, MinGW64 reported warnings for the cast operation between TickType_t and (void *) pointer because of different width. 64bit TickType_t should be used instead of 32bit if compiler is 64bit. * [WIN32-MingW Demo] Change printf() format specifiers from %u to %llu. Reason of change: %u specifier corrupts 64bit tick count because it supports only 32bit value. %llu can be used for both of 64bit value and 32bit value.(After casting to 64bit) * [WIN32-MingW Demo] Change type of some variables from uint32_t to UBaseType_t. Reason of change: These variables are cast to/from pointer type in existing codes. 64bit compiler(MinGW64) reports warnings for the cast operations between uint32_t and pointer type. UBaseType_t solves those warnings because it has same width as pointer type on both of MinGW32 and MinGW64. * [WIN32-MingW Demo] Change type of some variables from uint32_t to UBaseType_t. Same change as previous commit is applied to source codes which are built only on Debug configuration. * [WIN32-MingW Demo] Add brackets to the condition in #if statement. Behavior is not changed. Reason of change is to follow coding style guide of FreeRTOS. * Update "FreeRTOS/Source" submodule(FreeRTOS-kernel) to FreeRTOS#1008. * [WIN32-MingW Demo] Change type of one more variable from uint32_t to UBaseType_t. Additional modification for solving compiler warnings for the cast operation on MinGW64. * Update FreeRTOS-kernel submodule version in manifest.yml. * Modify prefix of variables to follow coding style guide. * Code review suggestions Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com> --------- Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com> Co-authored-by: ActoryOu <ousc@amazon.com> Co-authored-by: Gaurav-Aggarwal-AWS <33462878+aggarg@users.noreply.github.com> Co-authored-by: Gaurav Aggarwal <aggarg@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
In the MPU Wrappers functions registers are pushed to determine if the CPU is operating in a privileged mode
These registers are currently restored after the branch instruction, leading to a duplicate
popinstruction being placed into each MPU wrapper function.This PR moves the pop to be before the branch is taken, removing the duplicate instruction.
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.