Resolves #146: Registered new command for hostInfo #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Can one of the admins verify this patch? |
3 similar comments
| Can one of the admins verify this patch? |
| Can one of the admins verify this patch? |
| Can one of the admins verify this patch? |
| @fdb-build test this please |
apkar changed the title 
apkar reviewed Sep 30, 2019
thirdparty/bson-cpp/CMakeLists.txt Outdated
| "util/hex.h" | ||
| "util/misc.h" | ||
| "util/optime.h" | ||
| "system_info.h" |
There was a problem hiding this comment.
Haven't reviewed the complete code yet. One high level comment - we NEVER change any code in thirdparty directory for licensing reasons. It seems like the changes you made don't have to be in bson-cpp.
There was a problem hiding this comment.
Sure @apkar, we shall move them out of thirdparty directory and raise a commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR resolves #146
Registered new command for hostInfo and changes are verified in Ubuntu, CentOS and Mac OS.