Fix Dispatcher reset edge cases #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #38 +/- ## ========================================== - Coverage 97.31% 96.89% -0.42% ========================================== Files 10 10 Lines 484 483 -1 Branches 87 85 -2 ========================================== - Hits 471 468 -3 - Misses 9 11 +2 Partials 4 4
Continue to review full report at Codecov.
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Supersedes #33
@khmm12 Hiya 👋 I saw some more edge cases so I started a new branch that fixes this more strictly so we don't run into this again. Hope that makes sense 💯 I'll copy over your test though and will name you as a co-author on the PR :)