Fix for canvas font using points instead of pixels #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ixes line spacing issues where fonts are specified in points but line heights are specified in pixels. Remove extraneous "normal" string from definitions. TODO: Place both declarations somewhere shared, like FontFace or FontUtils or perhaps make measureText have multiple methods (maybe renamed to TextUtils if that's not confusing)
| The fact that we've been using pt for font size and px for line height has already been breaking user expectations. Better to make this change sooner than later. Looks good. |
mjohnston pushed a commit that referenced this pull request Feb 23, 2015
Fix for canvas font using points instead of pixels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Switch from using points to pixels because it seems that font size is specified in points while line height is specified in pixels (at least without unit conversions for line height to preserve points behavior).
Also fix extra "normal" string, and update examples.
This may break users expecting points for font sizes.