This repository was archived by the owner on Aug 20, 2025. It is now read-only.
Upgrade to TypeScript 3.2 and fix protocol types #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
TypeScript 3.2 brings typed `Function.call`, which has revealed a deficiency in our JSON-RPC type definitions. The `params` argument for the `RequestHandler` and `NotificationHandler` callbacks was incompatible with `undefined` in its union, even though an incoming RPC request could have its `params` property omitted. Correct this mistake by including `undefined` in the `RPCParams` union type. Finish fixing #5 by also allowing `params` to be omitted for notifications. Fix the unit tests which did not catch this issue before.
Hexxeh approved these changes Dec 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
TypeScript 3.2 brings typed
Function.call, which has revealed adeficiency in our JSON-RPC type definitions. The
paramsargument forthe
RequestHandlerandNotificationHandlercallbacks wasincompatible with
undefinedin its union, even though an incoming RPCrequest could have its
paramsproperty omitted. Correct this mistakeby including
undefinedin theRPCParamsunion type.Finish fixing #5 by also allowing
paramsto be omitted fornotifications. Fix the unit tests which did not catch this issue before.