Postfix for #8430 #8752
Merged
Postfix for #8430 #8752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dyemanov reviewed Oct 7, 2025
src/alice/alice.cpp Outdated
| if (any_error) | ||
| { | ||
| ALICE_print(24);// msg 24: Summary of validation errors\n | ||
| ALICE_print(24, SafeArg(), false);// msg 24: Summary of validation errors\n |
There was a problem hiding this comment.
Given that we know the service has been already started, I'd consider to do:
if (tdgbl->uSvc->isService()) tdgbl->uSvc->started();explicitly before this ALICE_print() call instead of hacking ALICE_print() itself for this particular case.
Changed `EXE_two_phase` and `EXE_action` so that `tdgbl->uSvc->started()` works correctly.
dyemanov approved these changes Nov 5, 2025
dyemanov pushed a commit that referenced this pull request Nov 6, 2025
* Fixed crash after calling incorrectly parametrized request * Patch: Fixed crash after calling incorrectly parametrized request * ALICE_print fix, isError flag added * Revert "ALICE_print fix, isError flag added" This reverts commit 24c74e1. * Fix incorrect order of procedure calls * `ALICE_print` was returned to previous state. Changed `EXE_two_phase` and `EXE_action` so that `tdgbl->uSvc->started()` works correctly. --------- Co-authored-by: bogdan.khavronin <bogdan.khavronin@red-soft.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As I see, there is a problem with fbsvcmgr again (#8431 (comment)), so I offer my solution. It is that
ALICE_printcallstdgbl->uSvc->started(), which immediately after the output of information releases the stream, which does not allow further output of information.