Refactor: Structured logging. #1201
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
| Rebase with |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Another piece of #1196.
The code has been rewritten from the ground up, though I've kept some names and structure, at least for this initial version.
IFbLogger->Microsoft.Extensions.Logging.ILogger<T>FbLogManager-> Probably better to rename it toFBLoggingConfiguration?LogMessages-> Converted to structured logging format.There are some warnings about libraries not tested with
.net5. What about to support.net6and up with compiler directives?In
.net6log messages can be generated in compile-time.