Skip to content
This repository was archived by the owner on Apr 29, 2022. It is now read-only.

Conversation

umgelurgel
Copy link
Contributor

Fixes #1154

This is what it would look like (copied the announcement bar content from 2017 page)

image

Copy link
Member

@malemburg malemburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise. Will the bar height adjust based on content or remain fixed ?

{% load cms_tags static %}

<script>
fetch('/sponsors')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making this dynamic will create SEO problems for the sponsors and also hinder converting the website to a static version after the conference. I think it would be better to use a standard Django servers side template for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point - updated the MR, it's cleaner this way, too.

@umgelurgel
Copy link
Contributor Author

Looks good otherwise. Will the bar height adjust based on content or remain fixed ?

The height is dynamic, based on the content.

@malemburg
Copy link
Member

BTW: I was originally thinking of something like this:

image

I.e. we make better use of the available screen space, highlight only a few items, and leave the remaining vertical sections as is (without the news one of course).

@malemburg
Copy link
Member

Here's the orange alpha backdrop PNG.
frontpage-updates-box-630px
(not sure whether Github compresses this further; I can provide the original if needed)

@umgelurgel
Copy link
Contributor Author

BTW: I was originally thinking of something like this:

In the future please provide the requirements when requesting new functionality, not when development is complete; the image provided for reference originally was from the ep2017 conference page. I'm not planning on updating the layout as part of this MR, I'm happy for someone else to take it over or for it to be addressed in a future MR, following the initial page release.

@malemburg
Copy link
Member

BTW: I was originally thinking of something like this:

In the future please provide the requirements when requesting new functionality, not when development is complete; the image provided for reference originally was from the ep2017 conference page. I'm not planning on updating the layout as part of this MR, I'm happy for someone else to take it over or for it to be addressed in a future MR, following the initial page release.

Fair enough. Please do consider asking for more details before going into the dev phase. The ticket only listed a high level requirement, without full detail, just so that the request doesn't get lost.

@aramboi
Copy link
Member

aramboi commented Mar 4, 2020

That rounded corners rectangle looks really ugly and out of place there. We could go with a semi-transparent background (square) of the same color. I can try to create a proof of concept today if @umgelurgel is not available to make this change.

@malemburg
Copy link
Member

I'll ask on the M&D WG for comments.

Here's variant without rounding:

image

@umgelurgel
Copy link
Contributor Author

Website with the changes:

image

Both height and width are adjusted automatically.

@umgelurgel umgelurgel force-pushed the issue-1154-add-announcement-bar branch from 10d567e to 7078c8e Compare March 5, 2020 19:49
Copy link
Member

@aramboi aramboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!!

@umgelurgel umgelurgel merged commit fcdf39e into dev/ep2020 Mar 5, 2020
@malemburg
Copy link
Member

malemburg commented Mar 5, 2020 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants