Skip to content

GH-9 Refactor updater to gitcheck. Improve API to check update. #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2023
Merged

GH-9 Refactor updater to gitcheck. Improve API to check update. #9

merged 1 commit into from
Jan 17, 2023

Conversation

Rollczi
Copy link
Member

@Rollczi Rollczi commented Jan 17, 2023 •
edited by P1otrulla
Loading

  • Change name of project to gitcheck.
  • Add git domain.GitRepository, GitTag, GitRelease etc...
  • Improve API to check update. GitCheck, GitCheckResult
  • Bump java version to 9. Add git domain.
  • Add unit tests for all classes.
  • Add option to implement git release provider. Add github release provider.
  • Exclude junit from json simple dependency.
  • Change name of license.txt to LICENSE.
  • Reduce jar size from 3.1MB to 65KB (-99,97%).
  • Use java 9 11 and 17 in CI build.
  • Separate build and publish.
  • Run CI build and test on every push to master and pull request to master.
@Rollczi
Change name of project to gitcheck. Bump java version to 9. Add git …
74c5d35 
…domain. Add unit tests for all classes. Add option to implement git release provider. Add github release provider. Exclude junit from json simple dependency. Change name of license.txt to LICENSE. Reduce jar size from 3.1MB to 65KB (-99,97%).
@Rollczi Rollczi changed the title Refactor updater to gitcheck. Improve API to check update. GH-9 Refactor updater to gitcheck. Improve API to check update. Jan 17, 2023
@Hyd3r1 Hyd3r1 requested review from Hyd3r1 and vLuckyyy January 17, 2023 23:24
vLuckyyy
vLuckyyy approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@vLuckyyy vLuckyyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the code seems to be well-written and I don't see any issues with it. The PR includes many positive elements such as bug fixes, new features, and improvements.
@vLuckyyy vLuckyyy merged commit 5b61e7a into master Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@Rollczi @Hyd3r1 @vLuckyyy