feat: Enhance Snippet Builder #46 #57
Conversation
| thanks @BochaberiDaisy ! I'll check it later today 😄 |
| Okay. I'll appreciate the feedback 😀 |
There was a problem hiding this comment.
Hi @BochaberiDaisy ! it's looking pretty good, but I noticed some things are not properly working. Could you check these?
bugs.mp4
Thanks again! I really appreciate your time. You are doing it very good
builder/main.js Outdated
| const snippetObject = JSON.parse(fileContent); | ||
| | ||
| const snippetDisplay = document.getElementById("snippets"); | ||
| snippetDisplay.innerText = JSON.stringify(snippetObject, null, 2); |
There was a problem hiding this comment.
This is good, I'm just missing the form to be filled too:
builder/index.html Outdated
| </calcite-popover-manager> | ||
| </span> | ||
| | ||
| <input type="file" id="import-snippet" accept=".json"> |
There was a problem hiding this comment.
Would you mind using the <calcite-input type="file" ...>? (doc here)
For UX purposes, could could add a sample file, just in case; maybe a sample.json with something like this:
{ "A JavaScript only snippet": { "scope": "javascript", "prefix": "myConsoleLog", "body": [ "console.log(\"Hello Map\");" ], "description": "Console log \"Hello Map\"" } } | @hhkaos, thank you for the feedback. Let me work on the changes and share. |
| Sure @BochaberiDaisy ! let me know if you need any additional help 😄 |
hhkaos left a comment
hhkaos left a comment There was a problem hiding this comment.
LGTM! Great work @BochaberiDaisy! 👏
2 participants
Fix: #46
@hhkaos, please review the PR.
Features added: