Adopt is dead, long live Zulu! #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| would appreciate elaboration on your change |
| Adopt no longer exists. Two options for v2 right now are 'temurin' or 'zulu'. The first one, 'temurin' is new, and doesn't have all the releases, e.g., the Temurin history starts from 8.0.302, 11.0.12, and 16.0.2, while Zulu supports all versions of these releases. |
| Right now you're testing only on '8', which is not a fixed version, but that is whatever the latest version of '8' is. You're recommended as a best practise to set the latest version of a release, as well as a fixed version, so that when your build breaks and the fixed version is green while the latest version is red, you'll know that the broken build is because of the latest version of the JDK and not because of anything in your own code. Here's an example: https://github.com/HdrHistogram/HdrHistogram/blob/master/.github/workflows/maven.yml |
Fgerthoffert requested changes May 5, 2023
| with: | ||
| java-version: '8' | ||
| distribution: 'adopt' | ||
| distribution: 'zulu' |
There was a problem hiding this comment.
Could you also update to zulu in the publish workflow ?
Merged
github-merge-queue bot referenced this pull request in camunda/camunda Apr 30, 2024
…ns to v21 (main) (#18094) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.github.graphql-java:graphql-java-annotations](https://togithub.com/graphql-java/graphql-java-annotations) | `9.1` -> `21.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>graphql-java/graphql-java-annotations (io.github.graphql-java:graphql-java-annotations)</summary> ### [`v21.1`](https://togithub.com/Enigmatis/graphql-java-annotations/releases/tag/v21.1) [Compare Source](https://togithub.com/graphql-java/graphql-java-annotations/compare/v9.1...v21.1) #### What's Changed - Fix for [issue#283](https://togithub.com/issue/graphql-java-annotations/issues/283) Renamed bundle.bnd to bnd.bnd to generate OSGi Metadata properly by [@​sergehuber](https://togithub.com/sergehuber) in [https://github.com/Enigmatis/graphql-java-annotations/pull/284](https://togithub.com/Enigmatis/graphql-java-annotations/pull/284) - Upgrade graphql-java by [@​manikandan-ravikumar](https://togithub.com/manikandan-ravikumar) in [https://github.com/Enigmatis/graphql-java-annotations/pull/287](https://togithub.com/Enigmatis/graphql-java-annotations/pull/287) - Let ID be every type, since it is allowed by by [@​EugenMayer](https://togithub.com/EugenMayer) in [https://github.com/Enigmatis/graphql-java-annotations/pull/289](https://togithub.com/Enigmatis/graphql-java-annotations/pull/289) - Adopt is dead, long live Zulu! by [@​geertjanw](https://togithub.com/geertjanw) in [https://github.com/Enigmatis/graphql-java-annotations/pull/279](https://togithub.com/Enigmatis/graphql-java-annotations/pull/279) - Change to zulu by [@​sergehuber](https://togithub.com/sergehuber) in [https://github.com/Enigmatis/graphql-java-annotations/pull/292](https://togithub.com/Enigmatis/graphql-java-annotations/pull/292) - Bump version graphql-java from 17.2 to 20.3 by [@​anatol-sialitski](https://togithub.com/anatol-sialitski) in [https://github.com/Enigmatis/graphql-java-annotations/pull/291](https://togithub.com/Enigmatis/graphql-java-annotations/pull/291) - Upgrade to GraphQL-Java 21 & Gradle 8.3 by [@​sergehuber](https://togithub.com/sergehuber) in [https://github.com/Enigmatis/graphql-java-annotations/pull/295](https://togithub.com/Enigmatis/graphql-java-annotations/pull/295) - Add Gradle Wrapper Validator to build job, fix build job by [@​BlasiusSecundus](https://togithub.com/BlasiusSecundus) in [https://github.com/Enigmatis/graphql-java-annotations/pull/293](https://togithub.com/Enigmatis/graphql-java-annotations/pull/293) - Add Bnd instructions by [@​geichelberger](https://togithub.com/geichelberger) in [https://github.com/Enigmatis/graphql-java-annotations/pull/294](https://togithub.com/Enigmatis/graphql-java-annotations/pull/294) - Use version 21.1 by [@​tdraier](https://togithub.com/tdraier) in [https://github.com/Enigmatis/graphql-java-annotations/pull/296](https://togithub.com/Enigmatis/graphql-java-annotations/pull/296) #### New Contributors - [@​manikandan-ravikumar](https://togithub.com/manikandan-ravikumar) made their first contribution in [https://github.com/Enigmatis/graphql-java-annotations/pull/287](https://togithub.com/Enigmatis/graphql-java-annotations/pull/287) - [@​EugenMayer](https://togithub.com/EugenMayer) made their first contribution in [https://github.com/Enigmatis/graphql-java-annotations/pull/289](https://togithub.com/Enigmatis/graphql-java-annotations/pull/289) - [@​geertjanw](https://togithub.com/geertjanw) made their first contribution in [https://github.com/Enigmatis/graphql-java-annotations/pull/279](https://togithub.com/Enigmatis/graphql-java-annotations/pull/279) - [@​anatol-sialitski](https://togithub.com/anatol-sialitski) made their first contribution in [https://github.com/Enigmatis/graphql-java-annotations/pull/291](https://togithub.com/Enigmatis/graphql-java-annotations/pull/291) - [@​BlasiusSecundus](https://togithub.com/BlasiusSecundus) made their first contribution in [https://github.com/Enigmatis/graphql-java-annotations/pull/293](https://togithub.com/Enigmatis/graphql-java-annotations/pull/293) - [@​geichelberger](https://togithub.com/geichelberger) made their first contribution in [https://github.com/Enigmatis/graphql-java-annotations/pull/294](https://togithub.com/Enigmatis/graphql-java-annotations/pull/294) **Full Changelog**: Enigmatis/graphql-java-annotations@v9.1...v21.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/camunda/zeebe). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhdXRvbWVyZ2UiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.