Skip to content

Conversation

@nklyshko
Copy link

@nklyshko nklyshko commented Aug 16, 2020

Changes:

  • added support for existing meta lines in source plugin.yml
  • added support for api-version meta item
  • removed rewrite of source file, because editing user's source code without backup is not good thing

Checklist:

  • Have you read text of project license?
  • Have you described maked changes in README or wiki?
  • Have you added changelog?
…lugin.yml, added support for api-version meta item
@nklyshko
Copy link
Author

Unfortunately, my tries to manual test changes locally was failed because i was unable to publish this plugin to maven local. If you can explain how to do this properly, I will check my changes in work.

Copy link
Member

@osipxd osipxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
Everything looks good except one small comment.

Now about your question:

my tries to manual test changes locally was failed because i was unable to publish this plugin to maven local

At this moment plugin in develop is broken, and I'm working on the fix in #38. It is a massive refactoring of the plugin. I think will be better to wait for this PR. I'll try to finish it ASAP and you will be able to test the plugin locally.

@osipxd osipxd mentioned this pull request Aug 18, 2020
@osipxd osipxd added this to the 0.9 milestone Aug 18, 2020
Copy link
Member

@osipxd osipxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thank you. I'll merge this PR after #38

@osipxd osipxd mentioned this pull request Jan 7, 2021
3 tasks
@osipxd osipxd closed this in #51 Jan 7, 2021
@osipxd
Copy link
Member

osipxd commented Jan 7, 2021

Thank you for your pull request. Plugin code base dramatically changed so I've implemented this feature myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants