Skip to content

[NO MERGE] optimize fee estimation test, re-include in regular list #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
instagibbs wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[NO MERGE] optimize fee estimation test, re-include in regular list #564

instagibbs wants to merge 1 commit into from

Conversation

@instagibbs
Copy link
Contributor

@instagibbs instagibbs commented Apr 5, 2019 •
edited
Loading

Turning off mempool consistency checks sped up this test by 30%.
@instagibbs
Copy link
Contributor Author

instagibbs commented Apr 5, 2019

Actually seems to work reasonably. Test took under 500 seconds, and whole suite in about 44 minutes.
@instagibbs instagibbs changed the title [WIP] optimize fee estimation test, re-include in regular list optimize fee estimation test, re-include in regular list Apr 10, 2019
@instagibbs
Copy link
Contributor Author

instagibbs commented Apr 10, 2019

It's passing consistently. Restarting one more time, @stevenroose could you ACK/merge if it passes again?
@instagibbs
Copy link
Contributor Author

instagibbs commented Apr 11, 2019

interesting, the section where it's supposed to recover in a few seconds failed to.

Timed out at this section:

# Don't make a block, race condition when pegin-invalid block # is awaiting further validation, nodes reject subsequent blocks # even ones they create print("Now waiting for node to re-evaluate peg-in witness failed block... should take a few seconds") self.sync_all(self.node_groups) print("Completed!\n")

One mempool was missing a tx to the end of the test. Wonder what happened there... leaving this PR open then.
@instagibbs instagibbs changed the title optimize fee estimation test, re-include in regular list [NO MERGE] optimize fee estimation test, re-include in regular list Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@instagibbs