fix: unblinded re/issuance for non-policy asset greater than 21 million #1445
Conversation
delta1 commented Apr 3, 2025
delta1 commented - test: add test for unblinded re/issuance greater than 21 million
- fix: unblinded re/issuance for greater than 21 million
Co-authored-by: Mihailo Milenkovic <mihailo.milenkovic84@gmail.com>
Co-authored-by: Mihailo Milenkovic <mihailo.milenkovic84@gmail.com>
| closes #1443 |
| utACK d3502ce |
| utACK d3502ce -- though this is a hardforking change and we need to be careful about where/how we deploy it. |
| Updated to enable this with a consensus parameter ( |
| Modified to remove This is technically a hard fork, but can be released safely in advance so long as block signers apply |
tomt1664 force-pushed the issues/1443 branch from 883c5c9 to fc82dbc Compare tomt1664 force-pushed the issues/1443 branch from fc82dbc to 0c6faca Compare tomt1664 force-pushed the issues/1443 branch 2 times, most recently from 41f3833 to 2b7dd1a Compare 
| | ||
| std::vector<std::string> elements_hidden_args = {"-con_fpowallowmindifficultyblocks", "-con_fpownoretargeting", "-con_nsubsidyhalvinginterval", "-con_bip16exception", "-con_bip34height", "-con_bip65height", "-con_bip66height", "-con_npowtargettimespan", "-con_npowtargetspacing", "-con_nrulechangeactivationthreshold", "-con_nminerconfirmationwindow", "-con_powlimit", "-con_bip34hash", "-con_nminimumchainwork", "-con_defaultassumevalid", "-npruneafterheight", "-fdefaultconsistencychecks", "-fmineblocksondemand", "-fallback_fee_enabled", "-pchmessagestart"}; | ||
| | ||
| argsman.AddArg("-acceptunlimitedissuances", strprintf("Relay and mine unblinded issuance transactions (default: %u)", DEFAULT_ACCEPT_UNLIMITED_ISSUANCES), ArgsManager::ALLOW_ANY, OptionsCategory::ELEMENTS); |
There was a problem hiding this comment.
Minor, can be done in followup: I think this could be slightly more descriptive
| argsman.AddArg("-acceptunlimitedissuances", strprintf("Relay and mine unblinded issuance transactions (default: %u)", DEFAULT_ACCEPT_UNLIMITED_ISSUANCES), ArgsManager::ALLOW_ANY, OptionsCategory::ELEMENTS); | |
| argsman.AddArg("-acceptunlimitedissuances", strprintf("Allow unblinded issuance amounts to exceed 21 million units (default: %u)", DEFAULT_ACCEPT_UNLIMITED_ISSUANCES), ArgsManager::ALLOW_ANY, OptionsCategory::ELEMENTS); |
3 participants
