Skip to content

fix: getnewaddress - don't blind bech32 addresses #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
psgreco merged 1 commit into from
Jul 19, 2023
Merged

fix: getnewaddress - don't blind bech32 addresses #1246

psgreco merged 1 commit into from
Jul 19, 2023

Conversation

@delta1
Copy link
Member

@delta1 delta1 commented Jul 14, 2023

fixes #1245 - getnewaddress will now return an unblinded bech32 address even when -blindedaddresses=1 in config
roconnor-blockstream
roconnor-blockstream reviewed Jul 14, 2023
View reviewed changes
@apoelstra
Copy link
Member

apoelstra commented Jul 18, 2023

059a4a6 looks fine to me.

Locally the following tests fail

elements-059a4a> feature_confidential_transactions.py | ✖ Failed | 1 s elements-059a4a> feature_sighash_rangeproof.py | ✖ Failed | 2 s elements-059a4a> rpc_signrawtransaction.py --legacy-wallet | ✖ Failed | 6 s

These look like real failures; they happen consistently.
@delta1
Copy link
Member Author

delta1 commented Jul 19, 2023

Thanks @apoelstra - fixed
apoelstra
apoelstra approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 49c3ea3
@psgreco psgreco merged commit 6802564 into ElementsProject:master Jul 19, 2023
@roconnor-blockstream
Copy link
Contributor

roconnor-blockstream commented Jul 19, 2023

Now I'm a bit concerned that this change will break existing workflows of people by unblinding their addresses on thm.
@apoelstra
Copy link
Member

apoelstra commented Jul 19, 2023

It may, but I think the old behavior was probably wrong. Not sure how best to handle this.
@psgreco
Copy link
Contributor

psgreco commented Jul 19, 2023

I think the old behavior was at least inconsistent, so I'm fine with a comment added to the release notes and this fix making things consistent
@delta1 delta1 deleted the issue-1245 branch July 20, 2023 05:13
@delta1 delta1 mentioned this pull request Jul 20, 2023
Closed
jamesdorfman added a commit to jamesdorfman/elements that referenced this pull request Aug 29, 2023
@jamesdorfman
Merge 6802564 into merged_master (Elements PR ElementsProject#1246)
d457ef7
@grubles grubles mentioned this pull request Nov 18, 2023
Closed
@delta1 delta1 mentioned this pull request Nov 20, 2023
Merged
@jamesdorfman jamesdorfman mentioned this pull request Nov 20, 2023
Merged
@warioishere warioishere mentioned this pull request Feb 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@delta1 @apoelstra @roconnor-blockstream @psgreco