Fix crash when creating large inputs #1014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ssertation failure
…uts fails "gracefully"
apoelstra force-pushed the 2021-06--fix-surjectionproof-crash branch from f806047 to f7e1fb6 Compare 
Member Author
| Rebased |
Contributor
| utACK f7e1fb6. Thanks, this was really annoying. |
apoelstra added a commit to apoelstra/elements that referenced this pull request Aug 31, 2021
This fixes an undetected merge conflict between ElementsProject#1014 and ElementsProject#900.
apoelstra added a commit that referenced this pull request Aug 31, 2021
…ew RPC changes c0936ba test: fix surjectionproof overflow functional test for new RPC changes (Andrew Poelstra) Pull request description: This fixes an undetected merge conflict between #1014 and #900. ACKs for top commit: gwillen: utACK c0936ba psgreco: UTACK c0936ba Tree-SHA512: a39d98db91d92f7e0e739e06d7a1bb13814d2bc7751cb6105a759af04ed0d61d206d1650f5e4e087feaeafcf1c482587b05b66d9cc497bc594a45df6bf23c07a
gwillen pushed a commit that referenced this pull request Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There isn't really any reasonable way to recover from this situation but we can at least gracefully fail instead of triggering an assertation failure.
Fixes #979
Fixes #880