Skip to content

fix: closes #961 #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hazel54 merged 1 commit into from
Mar 27, 2019
Merged

fix: closes #961 #962

hazel54 merged 1 commit into from
Mar 27, 2019

Conversation

@loadchange
Copy link
Collaborator

@loadchange loadchange commented Mar 14, 2019

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you are merging your commits to master branch.
  • Add some descriptions and refer relative issues for you PR.
  • Rebase your commits to make your pull request meaningful.
  • Make sure that your changes pass npm test, npm run lint and npm run build.

Changes in this pull request

  • MessageBox
  • Dialog
  • src/table/utils.js
@loadchange loadchange requested a review from hazel54 March 17, 2019 12:21
hazel54
hazel54 approved these changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@hazel54 hazel54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@hazel54 hazel54 merged commit fc5dad0 into ElemeFE:master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@loadchange @hazel54