Skip to content

Select: #998, fix scroll unlimited loop with PureComponent #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
loadchange merged 2 commits into from
May 16, 2020
Merged

Select: #998, fix scroll unlimited loop with PureComponent #1062

loadchange merged 2 commits into from
May 16, 2020

Conversation

@Emiya0306
Copy link
Contributor

@Emiya0306 Emiya0306 commented May 4, 2020 •
edited
Loading

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you are merging your commits to master branch.
  • Add some descriptions and refer relative issues for you PR.
  • Rebase your commits to make your pull request meaningful.
  • Make sure that your changes pass npm test, npm run lint and npm run build.

Changes in this pull request

  • Add PureComponent Feature
  • Fix dependency cycle error
  • No thing change in docs.
@Emiya0306
Copy link
Contributor Author

Emiya0306 commented May 4, 2020

@hazel54 @loadchange
Is any one can review this PR? Thanks!
#998
@loadchange loadchange self-requested a review May 16, 2020 00:49
@loadchange loadchange merged commit c3100c3 into ElemeFE:master May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@Emiya0306 @loadchange