Skip to content

Popover: Prevent hide if already hidden. Fix #1027 #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
will-shaw wants to merge 1 commit into from
Closed

Popover: Prevent hide if already hidden. Fix #1027 #1028

will-shaw wants to merge 1 commit into from

Conversation

@will-shaw
Copy link

@will-shaw will-shaw commented Nov 1, 2019 •
edited
Loading

Prevents unnecessary re-renders of all hidden popovers in the page.

  • Make sure you are merging your commits to master branch.
  • Add some descriptions and refer relative issues for you PR.
  • Rebase your commits to make your pull request meaningful.
  • Make sure that your changes pass npm test, npm run lint and npm run build.

Edit: My changes do not affect the failing tests, however the current master branch is already broken, I can rebase once fixed.

Changes in this pull request
Fixes #1027

  • Prevents click outside setting state to false if showPopper is already false.
@will-shaw
Prevent popover hide if already hidden. Fix #1027
d508510 
Prevents unnecessary re-renders of all hidden popovers in the page.
@will-shaw will-shaw changed the title Prevent popover hide if already hidden. Fix #1027 Popover: Prevent hide if already hidden. Fix #1027 Nov 18, 2019
@will-shaw will-shaw closed this Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@will-shaw