Add HTTP content-type for WebP and AVIF #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This PR extends the _setContentTypeFromPath method to correctly identify and assign Content-Type headers for .webp (image/webp) and .avif (image/avif) files. Additionally, all HTTP headers are now formatted in Title Case, aligning with RFC 7231 and improving consistency across responses. Developers are encouraged to adopt AVIF or WebP formats over legacy image types such as GIF, PNG, or JPEG. Both formats are fully supported by all major modern browsers and typically offer significant file size reductions (often 50% or more) without perceptible quality loss. Conversion of assets is straightforward using tools like squoosh.app (free and online), which supports batch optimization and visual comparisons across formats.
me-no-dev reviewed Jul 16, 2025
src/literals.h Outdated
| | ||
| namespace asyncsrv { | ||
| namespace asyncsrv | ||
| { |
There was a problem hiding this comment.
please do not change the styling
There was a problem hiding this comment.
I will add the label and see of lint solves that.
| @JosePineiro : please have a look at #230 thanks ! |
mathieucarbou approved these changes Jul 17, 2025
| This PR contains more than it says in the title. I suggest to split it in two PRs, one for adding the two types and another for changing the case of strings |
me-no-dev requests fulfilled: - please do not change the styling - to split it in two PRs
mathieucarbou approved these changes Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR extends the _setContentTypeFromPath method to correctly identify and assign Content-Type headers for .webp (image/webp) and .avif (image/avif) files. Additionally, all HTTP headers are now formatted in Title Case, aligning with RFC 7231 and improving consistency across responses.
Developers are encouraged to adopt AVIF or WebP formats over legacy image types such as GIF, PNG, or JPEG. Both formats are fully supported by all major modern browsers and typically offer significant file size reductions (often 50% or more) without perceptible quality loss.
Conversion of assets is straightforward using tools like squoosh.app (free and online), which supports batch optimization and visual comparisons across formats.