Skip to content

Conversation

@mminkoff
Copy link
Contributor

Hi,

The most recent commit sends options.picker to the filepicker.pick command when it used to, and should, just send options. I didn't change the pickAndStore code, though perhaps something needs to change there as well. As it was it broke submitting the options hash.

Or did you mean to have all the picking options now in a level down in the options hash? If so then perhaps the README should be updated to show that.

Thanks!

-Max

@lukemelia
Copy link
Contributor

@mminkoff per https://www.filepicker.com/documentation/file_ingestion/javascript_api/pick_and_store?v=v2, picker and store options are passed to filepicker as separate arguments, so I think the current behavior is master is appropriate.

@yonida
Copy link
Contributor

yonida commented Jun 8, 2015

@mminkoff you are right about the level down in the options.
For convention, the pick options should always be passed as options.picker and if you want to use pickAndStore you should pass options.store as well (the flag for using pickAndStore is options.useStore).
I will update the readme file.

@yonida yonida closed this Jun 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants