- Notifications
You must be signed in to change notification settings - Fork 30
Add sample selection models to DoubleML for R #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ble_ml_data_from_matrix
Ssm branch
| I think we should add some unit tests for the data backend, see #214 @petronelaj - do you think you could take care of this? Thanks! |
| Hello, just to make sure, the tests for cluster data should be in this file as well? |
| Hi @petronelaj in the last days I tried to move on with this PR. I think there are still a couple of todos which we should try to complete soon, see I also listed some points in #216 , which we would have to address before releasing the SSM models. Thank you! |
use TuningInstanceBatchSingleCrit instead of TuningInstanceSingleCrit
Description
Please describe all changes and additions.
In addition, you may want to comment on the diff in GitHub.
Reference to Issues or PRs
For documentation in user guide, see DoubleML/doubleml-docs#222
Comments
This brings the initial changes from #211 to
main(see the communication there). Original changes made by @petronelajPR Checklist
Please fill out this PR checklist (see our contributing guidelines for details).
R CMD checkand all (unit) tests (see our contributing guidelines for details).