Skip to content

Rename abstract methods #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 14, 2022
Merged

Rename abstract methods #163

merged 4 commits into from
Jun 14, 2022

Conversation

@MalteKurz
Copy link
Member

@MalteKurz MalteKurz commented Jun 13, 2022

Description

In alignment with the Python package (see DoubleML/doubleml-for-py#131), in this PR the abstract methods are renamed:

  • ml_nuisance_and_score_elements --> nuisance_est
  • ml_nuisance_tuning --> nuisance_tuning

Comments

Blocked by #161 (derived from there to prevent merge conflicts).

PR Checklist

  • The title of the pull request summarizes the changes made.
  • The PR contains a detailed description of all changes and additions.
  • The code passes R CMD check and all (unit) tests.
  • The changes adhere to the "mlr-style" standards.
@MalteKurz MalteKurz mentioned this pull request Jun 13, 2022
Merged
@MalteKurz MalteKurz merged commit bf78c51 into master Jun 14, 2022
@MalteKurz MalteKurz deleted the m-rename-abstract-methods branch June 15, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@MalteKurz