Use task_type instead of learner_class #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
internally use task_type instead of learner_class
fix task_type in PLIV
fix style
error for learners of class `AutoTuner`
add mlr3pipelines to Suggests
…ner`) add test for each of the causal models
update documentation for learners
MalteKurz approved these changes Nov 18, 2021
There was a problem hiding this comment.
Thanks, LGTM.
We may should check whether it makes sense to extend and / or adapt some things in the user guide chapter on learners: https://docs.doubleml.org/stable/guide/learners.html.
| Thank you. Yes, I'll change the user guide accordingly. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In this PR:
mlr3learner (i..e,LearnerRegrandLearnerClassif) use the learner'stask_typemlr3pipelines