Skip to content

Unit test adaptions #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Oct 26, 2021
Merged

Unit test adaptions #137

merged 18 commits into from
Oct 26, 2021

Conversation

@MalteKurz
Copy link
Member

@MalteKurz MalteKurz commented Oct 26, 2021 •
edited
Loading

  • Prevent glmnent learners in the CRAN unit tests.
  • Add a workflow which checks this on github actions.
  • Still run the tests with glmnet learners on github actions.
@MalteKurz
started fixing unit tests which rely on glmnet learner and fail on cr…
d262cdd 
…an solaris
@MalteKurz
add a unit test run on gh actions where we run unit tests like on cra…
363c933 
…n but remove glmnet before
@MalteKurz
combine if conditions
5002f5e
@MalteKurz
adapt name of gh actions workflow
1e96530
@MalteKurz
build without vignette after removing glmnet
7cc0cdb
@MalteKurz
build without vignette after removing glmnet
33bb823
@MalteKurz
must use args and build_args
e841d64
@MalteKurz
set _R_CHECK_FORCE_SUGGESTS_
274c033
@MalteKurz
Merge branch 'm-adapt-gh-actions-ci' of github.com:DoubleML/doubleml-…
9965950 
…for-r into m-fix46
@MalteKurz
do not use glmnet learner on cran due to solaris issues
05c3777
@MalteKurz
switch to non-glmnet learner in the unit test
246a32c
@MalteKurz
switch to non-glmnet learner for the unit test on cran; also change t…
46f867b 
…he hyperparameter to prevent #136
@MalteKurz
remove print command
703dd9e
@MalteKurz MalteKurz linked an issue Oct 26, 2021 that may be closed by this pull request
Failing unit test on CRAN solaris #46
Closed
@MalteKurz MalteKurz linked an issue Oct 26, 2021 that may be closed by this pull request
Unit test for the extraction of predictions fails for non-glmnet learner #138
Closed
@MalteKurz MalteKurz merged commit dcd73a2 into master Oct 26, 2021
@MalteKurz MalteKurz deleted the m-fix46 branch October 26, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

continuous integration CRAN unit tests

2 participants

@MalteKurz