Skip to content

Conversation

alichraghi
Copy link
Contributor

Description

Testing

TODO list:

Signed-off-by: Ali Cheraghi <alichraghi@proton.me>
Signed-off-by: Ali Cheraghi <alichraghi@proton.me>
@devshgraphicsprogramming devshgraphicsprogramming merged commit 4786926 into master Jan 31, 2025
1 check passed
@devshgraphicsprogramming devshgraphicsprogramming deleted the ali_profiles branch January 31, 2025 14:54
Comment on lines +230 to +231
"shaderDenormPreserveFloat32": true,
"shaderDenormPreserveFloat64": true,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how on earth did this happen if the Nvidia GPUs don't support that?

@devshgraphicsprogramming
Copy link
Member

Btw what values for VULKAN_HEADERS and PROFILES_DIR did you use here https://github.com/Devsh-Graphics-Programming/Nabla/tree/master/src/nbl/video/vulkan/profiles#how-i-generated-the-profiles as arguments to

$ python gen_profiles_file.py --registry "${VULKAN_HEADERS}/registry/vk.xml" --input "PROFILES_DIR" -o "PROFILES_DIR/../profiles.json" --profile-desc "DESCRIPTION" --profile-label "NAME" 
@alichraghi
Copy link
Contributor Author

can't remember but i was confident about the correctness. also cloned the latest tagged vulkan-headers/vulkan-registry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants