Patch 2.0.1 #23
Merged
Patch 2.0.1 #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The relative path will cause this error: Module build failed: @import "../../node_modules/bootstrap/scss/functions"; ^ File to import not found or unreadable: ../../node_modules/bootstrap/scss/functions. Parent style sheet: /Users/lucian/...../shards-ui/src/scss/shards.scss in /Users/lucian/...../shards-ui/src/scss/shards.scss (line 9, column 1) This happens because when used as a submodule, the relative path does not work anymore. The fix isn't ideal as it assumes project root is within search path.
Remove relative path as this will break building as submodule
Fix append and prepend input group incorrect z-index
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Patch 2.0.1 release PR.