change auth type from strin to enum #21862
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| allow_redirects: Optional[bool] = None | ||
| auth_token: Optional[AuthToken] = None | ||
| auth_type: Optional[str] = None | ||
| auth_type: Optional[Literal['basic', 'digest', 'ntlm', 'kerberos', 'aws']] = None | ||
| aws_host: Optional[str] = None |
There was a problem hiding this comment.
Changing auth_type to Literal['basic', 'digest', 'ntlm', 'kerberos', 'aws'] makes the field validation case-sensitive. The HTTP wrapper lowercases whatever string is provided (datadog_checks_base/datadog_checks/base/utils/http.py), so configurations using values like 'NTLM' or 'Kerberos' currently succeed. After this change those previously accepted values will fail validation before the normalization step, breaking existing deployments across integrations that rely on the HTTP spec. Consider accepting case-insensitive inputs or keeping the field as a free string and normalizing it.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
What does this PR do?
The option here I think is better as a enum since we only allow for a set of options. Doesn't change any functionality.