- Notifications
You must be signed in to change notification settings - Fork 314
Refactor to have -Xms
before -Xmx
, to be more human-friendly. #9751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
-Xms
before _Xmx
, to be more human-friendly.-Xms
before -Xmx
, to be more human-friendly. 🎯 Code Coverage 🔗 Commit SHA: 3a927f1 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~3a927f17e0, baseline=1.55.0-SNAPSHOT~b3220ae962 dateFormat X axisFormat %s section tracing Agent [baseline] (1.026 s) : 0, 1026324 Total [baseline] (8.706 s) : 0, 8705502 Agent [candidate] (1.016 s) : 0, 1016011 Total [candidate] (8.651 s) : 0, 8650955 section iast Agent [baseline] (1.153 s) : 0, 1152850 Total [baseline] (9.281 s) : 0, 9281176 Agent [candidate] (1.151 s) : 0, 1151361 Total [candidate] (9.298 s) : 0, 9297943
gantt title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~3a927f17e0, baseline=1.55.0-SNAPSHOT~b3220ae962 dateFormat X axisFormat %s section tracing crashtracking [baseline] (1.493 ms) : 0, 1493 crashtracking [candidate] (1.456 ms) : 0, 1456 BytebuddyAgent [baseline] (701.201 ms) : 0, 701201 BytebuddyAgent [candidate] (691.807 ms) : 0, 691807 GlobalTracer [baseline] (242.941 ms) : 0, 242941 GlobalTracer [candidate] (241.331 ms) : 0, 241331 AppSec [baseline] (32.626 ms) : 0, 32626 AppSec [candidate] (32.394 ms) : 0, 32394 Debugger [baseline] (6.552 ms) : 0, 6552 Debugger [candidate] (6.339 ms) : 0, 6339 Remote Config [baseline] (710.327 µs) : 0, 710 Remote Config [candidate] (704.213 µs) : 0, 704 Telemetry [baseline] (9.31 ms) : 0, 9310 Telemetry [candidate] (9.305 ms) : 0, 9305 Flare Poller [baseline] (10.215 ms) : 0, 10215 Flare Poller [candidate] (11.637 ms) : 0, 11637 section iast crashtracking [baseline] (1.49 ms) : 0, 1490 crashtracking [candidate] (1.496 ms) : 0, 1496 BytebuddyAgent [baseline] (816.732 ms) : 0, 816732 BytebuddyAgent [candidate] (816.004 ms) : 0, 816004 GlobalTracer [baseline] (231.792 ms) : 0, 231792 GlobalTracer [candidate] (231.036 ms) : 0, 231036 AppSec [baseline] (35.071 ms) : 0, 35071 AppSec [candidate] (35.103 ms) : 0, 35103 Debugger [baseline] (6.125 ms) : 0, 6125 Debugger [candidate] (6.108 ms) : 0, 6108 Remote Config [baseline] (609.897 µs) : 0, 610 Remote Config [candidate] (606.122 µs) : 0, 606 Telemetry [baseline] (8.618 ms) : 0, 8618 Telemetry [candidate] (8.627 ms) : 0, 8627 Flare Poller [baseline] (4.227 ms) : 0, 4227 Flare Poller [candidate] (4.278 ms) : 0, 4278 IAST [baseline] (26.611 ms) : 0, 26611 IAST [candidate] (26.595 ms) : 0, 26595 Startup time reports for petclinicgantt title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~3a927f17e0, baseline=1.55.0-SNAPSHOT~b3220ae962 dateFormat X axisFormat %s section tracing Agent [baseline] (1.016 s) : 0, 1016361 Total [baseline] (10.704 s) : 0, 10703774 Agent [candidate] (1.016 s) : 0, 1016022 Total [candidate] (10.694 s) : 0, 10693910 section appsec Agent [baseline] (1.197 s) : 0, 1196559 Total [baseline] (11.035 s) : 0, 11035100 Agent [candidate] (1.19 s) : 0, 1190435 Total [candidate] (11.003 s) : 0, 11003190 section iast Agent [baseline] (1.15 s) : 0, 1149669 Total [baseline] (10.988 s) : 0, 10987877 Agent [candidate] (1.152 s) : 0, 1151856 Total [candidate] (11.015 s) : 0, 11014813 section profiling Agent [baseline] (1.164 s) : 0, 1164107 Total [baseline] (11.022 s) : 0, 11021679 Agent [candidate] (1.161 s) : 0, 1160781 Total [candidate] (11.03 s) : 0, 11030431
gantt title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~3a927f17e0, baseline=1.55.0-SNAPSHOT~b3220ae962 dateFormat X axisFormat %s section tracing crashtracking [baseline] (1.493 ms) : 0, 1493 crashtracking [candidate] (1.459 ms) : 0, 1459 BytebuddyAgent [baseline] (692.718 ms) : 0, 692718 BytebuddyAgent [candidate] (693.555 ms) : 0, 693555 GlobalTracer [baseline] (241.882 ms) : 0, 241882 GlobalTracer [candidate] (241.588 ms) : 0, 241588 AppSec [baseline] (32.415 ms) : 0, 32415 AppSec [candidate] (32.406 ms) : 0, 32406 Debugger [baseline] (6.398 ms) : 0, 6398 Debugger [candidate] (6.429 ms) : 0, 6429 Remote Config [baseline] (700.043 µs) : 0, 700 Remote Config [candidate] (691.652 µs) : 0, 692 Telemetry [baseline] (9.273 ms) : 0, 9273 Telemetry [candidate] (9.326 ms) : 0, 9326 Flare Poller [baseline] (10.363 ms) : 0, 10363 Flare Poller [candidate] (9.421 ms) : 0, 9421 section appsec crashtracking [baseline] (1.47 ms) : 0, 1470 crashtracking [candidate] (1.465 ms) : 0, 1465 BytebuddyAgent [baseline] (720.598 ms) : 0, 720598 BytebuddyAgent [candidate] (715.095 ms) : 0, 715095 GlobalTracer [baseline] (234.498 ms) : 0, 234498 GlobalTracer [candidate] (234.087 ms) : 0, 234087 AppSec [baseline] (174.898 ms) : 0, 174898 AppSec [candidate] (175.124 ms) : 0, 175124 Debugger [baseline] (6.1 ms) : 0, 6100 Debugger [candidate] (6.12 ms) : 0, 6120 Remote Config [baseline] (634.593 µs) : 0, 635 Remote Config [candidate] (633.031 µs) : 0, 633 Telemetry [baseline] (8.515 ms) : 0, 8515 Telemetry [candidate] (8.364 ms) : 0, 8364 Flare Poller [baseline] (3.912 ms) : 0, 3912 Flare Poller [candidate] (3.869 ms) : 0, 3869 IAST [baseline] (24.718 ms) : 0, 24718 IAST [candidate] (24.698 ms) : 0, 24698 section iast crashtracking [baseline] (1.463 ms) : 0, 1463 crashtracking [candidate] (1.455 ms) : 0, 1455 BytebuddyAgent [baseline] (814.624 ms) : 0, 814624 BytebuddyAgent [candidate] (816.323 ms) : 0, 816323 GlobalTracer [baseline] (230.991 ms) : 0, 230991 GlobalTracer [candidate] (231.371 ms) : 0, 231371 AppSec [baseline] (35.004 ms) : 0, 35004 AppSec [candidate] (35.048 ms) : 0, 35048 Debugger [baseline] (6.13 ms) : 0, 6130 Debugger [candidate] (6.202 ms) : 0, 6202 Remote Config [baseline] (609.69 µs) : 0, 610 Remote Config [candidate] (615.239 µs) : 0, 615 Telemetry [baseline] (8.638 ms) : 0, 8638 Telemetry [candidate] (8.72 ms) : 0, 8720 Flare Poller [baseline] (4.297 ms) : 0, 4297 Flare Poller [candidate] (4.19 ms) : 0, 4190 IAST [baseline] (26.392 ms) : 0, 26392 IAST [candidate] (26.391 ms) : 0, 26391 section profiling ProfilingAgent [baseline] (110.428 ms) : 0, 110428 ProfilingAgent [candidate] (107.515 ms) : 0, 107515 crashtracking [baseline] (1.44 ms) : 0, 1440 crashtracking [candidate] (1.432 ms) : 0, 1432 BytebuddyAgent [baseline] (720.546 ms) : 0, 720546 BytebuddyAgent [candidate] (721.359 ms) : 0, 721359 GlobalTracer [baseline] (218.105 ms) : 0, 218105 GlobalTracer [candidate] (217.476 ms) : 0, 217476 AppSec [baseline] (32.724 ms) : 0, 32724 AppSec [candidate] (32.336 ms) : 0, 32336 Debugger [baseline] (7.275 ms) : 0, 7275 Debugger [candidate] (7.288 ms) : 0, 7288 Remote Config [baseline] (744.873 µs) : 0, 745 Remote Config [candidate] (829.008 µs) : 0, 829 Telemetry [baseline] (15.708 ms) : 0, 15708 Telemetry [candidate] (15.36 ms) : 0, 15360 Flare Poller [baseline] (4.138 ms) : 0, 4138 Flare Poller [candidate] (4.177 ms) : 0, 4177 Profiling [baseline] (111.434 ms) : 0, 111434 Profiling [candidate] (108.375 ms) : 0, 108375 LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~3a927f17e0, baseline=1.55.0-SNAPSHOT~b3220ae962 dateFormat X axisFormat %s section baseline no_agent (4.211 ms) : 4164, 4258 . : milestone, 4211, iast (9.769 ms) : 9602, 9936 . : milestone, 9769, iast_FULL (14.155 ms) : 13873, 14438 . : milestone, 14155, iast_GLOBAL (10.631 ms) : 10436, 10826 . : milestone, 10631, profiling (8.791 ms) : 8635, 8946 . : milestone, 8791, tracing (7.573 ms) : 7459, 7687 . : milestone, 7573, section candidate no_agent (4.217 ms) : 4163, 4271 . : milestone, 4217, iast (9.681 ms) : 9516, 9846 . : milestone, 9681, iast_FULL (14.328 ms) : 14042, 14614 . : milestone, 14328, iast_GLOBAL (11.067 ms) : 10869, 11265 . : milestone, 11067, profiling (8.51 ms) : 8373, 8648 . : milestone, 8510, tracing (7.572 ms) : 7465, 7679 . : milestone, 7572,
Request duration reports for petclinicgantt title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~3a927f17e0, baseline=1.55.0-SNAPSHOT~b3220ae962 dateFormat X axisFormat %s section baseline no_agent (36.098 ms) : 35810, 36386 . : milestone, 36098, appsec (48.986 ms) : 48537, 49434 . : milestone, 48986, code_origins (43.787 ms) : 43416, 44159 . : milestone, 43787, iast (45.531 ms) : 45126, 45935 . : milestone, 45531, profiling (49.529 ms) : 49084, 49973 . : milestone, 49529, tracing (44.26 ms) : 43873, 44647 . : milestone, 44260, section candidate no_agent (37.259 ms) : 36955, 37563 . : milestone, 37259, appsec (47.548 ms) : 47132, 47964 . : milestone, 47548, code_origins (45.026 ms) : 44628, 45424 . : milestone, 45026, iast (45.078 ms) : 44690, 45466 . : milestone, 45078, profiling (48.88 ms) : 48400, 49360 . : milestone, 48880, tracing (44.425 ms) : 44036, 44815 . : milestone, 44425,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~3a927f17e0, baseline=1.55.0-SNAPSHOT~b3220ae962 dateFormat X axisFormat %s section baseline no_agent (1.479 ms) : 1467, 1490 . : milestone, 1479, appsec (3.716 ms) : 3498, 3935 . : milestone, 3716, iast (2.203 ms) : 2140, 2267 . : milestone, 2203, iast_GLOBAL (2.249 ms) : 2185, 2313 . : milestone, 2249, profiling (2.084 ms) : 2030, 2137 . : milestone, 2084, tracing (2.023 ms) : 1973, 2072 . : milestone, 2023, section candidate no_agent (1.478 ms) : 1466, 1489 . : milestone, 1478, appsec (3.741 ms) : 3522, 3961 . : milestone, 3741, iast (2.201 ms) : 2138, 2265 . : milestone, 2201, iast_GLOBAL (2.25 ms) : 2186, 2314 . : milestone, 2250, profiling (2.056 ms) : 2005, 2107 . : milestone, 2056, tracing (2.014 ms) : 1964, 2063 . : milestone, 2014,
Execution time for biojavagantt title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~3a927f17e0, baseline=1.55.0-SNAPSHOT~b3220ae962 dateFormat X axisFormat %s section baseline no_agent (15.052 s) : 15052000, 15052000 . : milestone, 15052000, appsec (14.868 s) : 14868000, 14868000 . : milestone, 14868000, iast (18.644 s) : 18644000, 18644000 . : milestone, 18644000, iast_GLOBAL (18.038 s) : 18038000, 18038000 . : milestone, 18038000, profiling (15.463 s) : 15463000, 15463000 . : milestone, 15463000, tracing (15.256 s) : 15256000, 15256000 . : milestone, 15256000, section candidate no_agent (15.021 s) : 15021000, 15021000 . : milestone, 15021000, appsec (15.295 s) : 15295000, 15295000 . : milestone, 15295000, iast (18.648 s) : 18648000, 18648000 . : milestone, 18648000, iast_GLOBAL (18.235 s) : 18235000, 18235000 . : milestone, 18235000, profiling (15.503 s) : 15503000, 15503000 . : milestone, 15503000, tracing (15.336 s) : 15336000, 15336000 . : milestone, 15336000,
|
What Does This Do
Refactors JVM option ordering so that -Xms (initial heap size) appears before -Xmx (maximum heap size) in build scripts.
Motivation
Having a consistent ordering helps prevent subtle errors when modifying build configurations.
Additional Notes
For humans, it’s easier to reason about heap settings as a “left bound → right bound” pair — min before max.