- Notifications
You must be signed in to change notification settings - Fork 314
Enforce a JDK 21 to run Gradle #9747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
bric3 wants to merge 1 commit into master Choose a base branch from bdu/test-decoupling-on-jdk21
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
+1 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for petclinicgantt title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~cb8142494a, baseline=1.55.0-SNAPSHOT~7950d54fef dateFormat X axisFormat %s section tracing Agent [baseline] (1.016 s) : 0, 1015627 Total [baseline] (10.673 s) : 0, 10673302 Agent [candidate] (1.016 s) : 0, 1015908 Total [candidate] (10.715 s) : 0, 10714972 section appsec Agent [baseline] (1.194 s) : 0, 1193699 Total [baseline] (11.041 s) : 0, 11041344 Agent [candidate] (1.198 s) : 0, 1198499 Total [candidate] (11.071 s) : 0, 11070802 section iast Agent [baseline] (1.153 s) : 0, 1152603 Total [baseline] (11.055 s) : 0, 11054677 Agent [candidate] (1.146 s) : 0, 1145836 Total [candidate] (11.086 s) : 0, 11085855 section profiling Agent [baseline] (1.161 s) : 0, 1160646 Total [baseline] (11.093 s) : 0, 11093262 Agent [candidate] (1.16 s) : 0, 1160282 Total [candidate] (11.048 s) : 0, 11048063
gantt title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~cb8142494a, baseline=1.55.0-SNAPSHOT~7950d54fef dateFormat X axisFormat %s section tracing crashtracking [baseline] (1.46 ms) : 0, 1460 crashtracking [candidate] (1.447 ms) : 0, 1447 BytebuddyAgent [baseline] (693.369 ms) : 0, 693369 BytebuddyAgent [candidate] (693.4 ms) : 0, 693400 GlobalTracer [baseline] (241.444 ms) : 0, 241444 GlobalTracer [candidate] (241.995 ms) : 0, 241995 AppSec [baseline] (32.289 ms) : 0, 32289 AppSec [candidate] (32.123 ms) : 0, 32123 Debugger [baseline] (6.378 ms) : 0, 6378 Debugger [candidate] (6.386 ms) : 0, 6386 Remote Config [baseline] (699.981 µs) : 0, 700 Remote Config [candidate] (696.928 µs) : 0, 697 Telemetry [baseline] (9.28 ms) : 0, 9280 Telemetry [candidate] (9.283 ms) : 0, 9283 Flare Poller [baseline] (9.514 ms) : 0, 9514 Flare Poller [candidate] (9.452 ms) : 0, 9452 section appsec crashtracking [baseline] (1.455 ms) : 0, 1455 crashtracking [candidate] (1.462 ms) : 0, 1462 BytebuddyAgent [baseline] (717.669 ms) : 0, 717669 BytebuddyAgent [candidate] (721.074 ms) : 0, 721074 GlobalTracer [baseline] (234.016 ms) : 0, 234016 GlobalTracer [candidate] (235.215 ms) : 0, 235215 AppSec [baseline] (175.316 ms) : 0, 175316 AppSec [candidate] (175.458 ms) : 0, 175458 Debugger [baseline] (6.152 ms) : 0, 6152 Debugger [candidate] (6.141 ms) : 0, 6141 Remote Config [baseline] (635.131 µs) : 0, 635 Remote Config [candidate] (631.203 µs) : 0, 631 Telemetry [baseline] (8.52 ms) : 0, 8520 Telemetry [candidate] (8.44 ms) : 0, 8440 Flare Poller [baseline] (3.936 ms) : 0, 3936 Flare Poller [candidate] (3.867 ms) : 0, 3867 IAST [baseline] (24.917 ms) : 0, 24917 IAST [candidate] (24.969 ms) : 0, 24969 section iast crashtracking [baseline] (1.471 ms) : 0, 1471 crashtracking [candidate] (1.459 ms) : 0, 1459 BytebuddyAgent [baseline] (815.404 ms) : 0, 815404 BytebuddyAgent [candidate] (812.047 ms) : 0, 812047 GlobalTracer [baseline] (232.547 ms) : 0, 232547 GlobalTracer [candidate] (230.135 ms) : 0, 230135 AppSec [baseline] (35.048 ms) : 0, 35048 AppSec [candidate] (34.942 ms) : 0, 34942 Debugger [baseline] (6.217 ms) : 0, 6217 Debugger [candidate] (6.164 ms) : 0, 6164 Remote Config [baseline] (620.511 µs) : 0, 621 Remote Config [candidate] (609.486 µs) : 0, 609 Telemetry [baseline] (8.818 ms) : 0, 8818 Telemetry [candidate] (8.49 ms) : 0, 8490 Flare Poller [baseline] (4.156 ms) : 0, 4156 Flare Poller [candidate] (4.249 ms) : 0, 4249 IAST [baseline] (26.705 ms) : 0, 26705 IAST [candidate] (26.211 ms) : 0, 26211 section profiling ProfilingAgent [baseline] (108.848 ms) : 0, 108848 ProfilingAgent [candidate] (107.771 ms) : 0, 107771 crashtracking [baseline] (1.423 ms) : 0, 1423 crashtracking [candidate] (1.431 ms) : 0, 1431 BytebuddyAgent [baseline] (720.29 ms) : 0, 720290 BytebuddyAgent [candidate] (721.128 ms) : 0, 721128 GlobalTracer [baseline] (217.333 ms) : 0, 217333 GlobalTracer [candidate] (217.679 ms) : 0, 217679 AppSec [baseline] (32.379 ms) : 0, 32379 AppSec [candidate] (32.272 ms) : 0, 32272 Debugger [baseline] (6.516 ms) : 0, 6516 Debugger [candidate] (6.519 ms) : 0, 6519 Remote Config [baseline] (1.523 ms) : 0, 1523 Remote Config [candidate] (804.405 µs) : 0, 804 Telemetry [baseline] (15.406 ms) : 0, 15406 Telemetry [candidate] (15.867 ms) : 0, 15867 Flare Poller [baseline] (4.134 ms) : 0, 4134 Flare Poller [candidate] (4.066 ms) : 0, 4066 Profiling [baseline] (109.717 ms) : 0, 109717 Profiling [candidate] (108.37 ms) : 0, 108370 Startup time reports for insecure-bankgantt title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~cb8142494a, baseline=1.55.0-SNAPSHOT~7950d54fef dateFormat X axisFormat %s section tracing Agent [baseline] (1.017 s) : 0, 1017268 Total [baseline] (8.691 s) : 0, 8690503 Agent [candidate] (1.017 s) : 0, 1017186 Total [candidate] (8.654 s) : 0, 8653516 section iast Agent [baseline] (1.148 s) : 0, 1148170 Total [baseline] (9.281 s) : 0, 9280819 Agent [candidate] (1.156 s) : 0, 1156406 Total [candidate] (9.292 s) : 0, 9292200
gantt title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~cb8142494a, baseline=1.55.0-SNAPSHOT~7950d54fef dateFormat X axisFormat %s section tracing crashtracking [baseline] (1.465 ms) : 0, 1465 crashtracking [candidate] (1.461 ms) : 0, 1461 BytebuddyAgent [baseline] (694.271 ms) : 0, 694271 BytebuddyAgent [candidate] (693.294 ms) : 0, 693294 GlobalTracer [baseline] (241.974 ms) : 0, 241974 GlobalTracer [candidate] (241.861 ms) : 0, 241861 AppSec [baseline] (32.6 ms) : 0, 32600 AppSec [candidate] (32.203 ms) : 0, 32203 Debugger [baseline] (6.493 ms) : 0, 6493 Debugger [candidate] (6.381 ms) : 0, 6381 Remote Config [baseline] (701.322 µs) : 0, 701 Remote Config [candidate] (694.7 µs) : 0, 695 Telemetry [baseline] (9.336 ms) : 0, 9336 Telemetry [candidate] (9.281 ms) : 0, 9281 Flare Poller [baseline] (9.269 ms) : 0, 9269 Flare Poller [candidate] (10.995 ms) : 0, 10995 section iast crashtracking [baseline] (1.491 ms) : 0, 1491 crashtracking [candidate] (1.476 ms) : 0, 1476 BytebuddyAgent [baseline] (813.733 ms) : 0, 813733 BytebuddyAgent [candidate] (819.8 ms) : 0, 819800 GlobalTracer [baseline] (230.513 ms) : 0, 230513 GlobalTracer [candidate] (231.737 ms) : 0, 231737 IAST [baseline] (27.171 ms) : 0, 27171 IAST [candidate] (26.751 ms) : 0, 26751 AppSec [baseline] (34.338 ms) : 0, 34338 AppSec [candidate] (35.456 ms) : 0, 35456 Debugger [baseline] (6.128 ms) : 0, 6128 Debugger [candidate] (6.148 ms) : 0, 6148 Remote Config [baseline] (599.404 µs) : 0, 599 Remote Config [candidate] (605.993 µs) : 0, 606 Telemetry [baseline] (8.537 ms) : 0, 8537 Telemetry [candidate] (8.628 ms) : 0, 8628 Flare Poller [baseline] (4.272 ms) : 0, 4272 Flare Poller [candidate] (4.232 ms) : 0, 4232 LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 4 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~cb8142494a, baseline=1.55.0-SNAPSHOT~7950d54fef dateFormat X axisFormat %s section baseline no_agent (4.296 ms) : 4247, 4345 . : milestone, 4296, iast (9.882 ms) : 9713, 10050 . : milestone, 9882, iast_FULL (14.169 ms) : 13893, 14446 . : milestone, 14169, iast_GLOBAL (9.913 ms) : 9740, 10087 . : milestone, 9913, profiling (8.75 ms) : 8617, 8884 . : milestone, 8750, tracing (7.532 ms) : 7427, 7638 . : milestone, 7532, section candidate no_agent (4.506 ms) : 4453, 4558 . : milestone, 4506, iast (10.302 ms) : 10121, 10484 . : milestone, 10302, iast_FULL (13.782 ms) : 13513, 14052 . : milestone, 13782, iast_GLOBAL (10.201 ms) : 10021, 10381 . : milestone, 10201, profiling (8.745 ms) : 8603, 8887 . : milestone, 8745, tracing (7.867 ms) : 7752, 7983 . : milestone, 7867,
Request duration reports for petclinicgantt title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~cb8142494a, baseline=1.55.0-SNAPSHOT~7950d54fef dateFormat X axisFormat %s section baseline no_agent (36.491 ms) : 36196, 36786 . : milestone, 36491, appsec (47.472 ms) : 47057, 47888 . : milestone, 47472, code_origins (45.05 ms) : 44660, 45440 . : milestone, 45050, iast (46.027 ms) : 45642, 46412 . : milestone, 46027, profiling (49.752 ms) : 49270, 50234 . : milestone, 49752, tracing (44.983 ms) : 44595, 45371 . : milestone, 44983, section candidate no_agent (37.034 ms) : 36735, 37333 . : milestone, 37034, appsec (50.038 ms) : 49607, 50470 . : milestone, 50038, code_origins (43.172 ms) : 42801, 43543 . : milestone, 43172, iast (44.756 ms) : 44373, 45138 . : milestone, 44756, profiling (48.834 ms) : 48399, 49269 . : milestone, 48834, tracing (42.665 ms) : 42287, 43043 . : milestone, 42665,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~cb8142494a, baseline=1.55.0-SNAPSHOT~7950d54fef dateFormat X axisFormat %s section baseline no_agent (14.833 s) : 14833000, 14833000 . : milestone, 14833000, appsec (15.077 s) : 15077000, 15077000 . : milestone, 15077000, iast (18.379 s) : 18379000, 18379000 . : milestone, 18379000, iast_GLOBAL (18.053 s) : 18053000, 18053000 . : milestone, 18053000, profiling (15.622 s) : 15622000, 15622000 . : milestone, 15622000, tracing (15.253 s) : 15253000, 15253000 . : milestone, 15253000, section candidate no_agent (15.543 s) : 15543000, 15543000 . : milestone, 15543000, appsec (14.862 s) : 14862000, 14862000 . : milestone, 14862000, iast (18.579 s) : 18579000, 18579000 . : milestone, 18579000, iast_GLOBAL (17.914 s) : 17914000, 17914000 . : milestone, 17914000, profiling (15.409 s) : 15409000, 15409000 . : milestone, 15409000, tracing (15.085 s) : 15085000, 15085000 . : milestone, 15085000,
Execution time for tomcatgantt title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~cb8142494a, baseline=1.55.0-SNAPSHOT~7950d54fef dateFormat X axisFormat %s section baseline no_agent (1.477 ms) : 1466, 1489 . : milestone, 1477, appsec (3.701 ms) : 3481, 3920 . : milestone, 3701, iast (2.201 ms) : 2138, 2265 . : milestone, 2201, iast_GLOBAL (2.235 ms) : 2171, 2298 . : milestone, 2235, profiling (2.487 ms) : 2316, 2657 . : milestone, 2487, tracing (2.012 ms) : 1963, 2062 . : milestone, 2012, section candidate no_agent (1.475 ms) : 1463, 1487 . : milestone, 1475, appsec (3.724 ms) : 3504, 3943 . : milestone, 3724, iast (2.199 ms) : 2136, 2263 . : milestone, 2199, iast_GLOBAL (2.244 ms) : 2180, 2308 . : milestone, 2244, profiling (2.037 ms) : 1987, 2088 . : milestone, 2037, tracing (2.023 ms) : 1974, 2073 . : milestone, 2023,
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: tooling Build & Tooling tag: do not merge Do not merge changes tag: no release notes Changes to exclude from release notes
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What Does This Do
Enforce JDK 21 to run the Gradle Daemon. (Requires spotbugs to be bumped)
This current approach has problems with IntelliJ
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any useful labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]