- Notifications
You must be signed in to change notification settings - Fork 314
Lazier way to configure grpc tasks #9735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎯 Code Coverage 🔗 Commit SHA: b29e71d | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 6 unstable metrics.
Startup time reports for petclinicgantt title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~b29e71d67f, baseline=1.55.0-SNAPSHOT~d2f5bb4248 dateFormat X axisFormat %s section tracing Agent [baseline] (1.018 s) : 0, 1018189 Total [baseline] (10.673 s) : 0, 10672869 Agent [candidate] (1.017 s) : 0, 1017104 Total [candidate] (10.676 s) : 0, 10675660 section appsec Agent [baseline] (1.193 s) : 0, 1193151 Total [baseline] (11.023 s) : 0, 11022913 Agent [candidate] (1.195 s) : 0, 1194591 Total [candidate] (11.009 s) : 0, 11008813 section iast Agent [baseline] (1.157 s) : 0, 1156512 Total [baseline] (11.043 s) : 0, 11042645 Agent [candidate] (1.149 s) : 0, 1148810 Total [candidate] (10.987 s) : 0, 10987217 section profiling Agent [baseline] (1.164 s) : 0, 1164410 Total [baseline] (10.991 s) : 0, 10991010 Agent [candidate] (1.157 s) : 0, 1157459 Total [candidate] (11.114 s) : 0, 11113749
gantt title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~b29e71d67f, baseline=1.55.0-SNAPSHOT~d2f5bb4248 dateFormat X axisFormat %s section tracing crashtracking [baseline] (1.458 ms) : 0, 1458 crashtracking [candidate] (1.45 ms) : 0, 1450 BytebuddyAgent [baseline] (694.24 ms) : 0, 694240 BytebuddyAgent [candidate] (692.796 ms) : 0, 692796 GlobalTracer [baseline] (241.516 ms) : 0, 241516 GlobalTracer [candidate] (241.811 ms) : 0, 241811 AppSec [baseline] (32.483 ms) : 0, 32483 AppSec [candidate] (32.502 ms) : 0, 32502 Debugger [baseline] (6.437 ms) : 0, 6437 Debugger [candidate] (6.421 ms) : 0, 6421 Remote Config [baseline] (708.962 µs) : 0, 709 Remote Config [candidate] (702.068 µs) : 0, 702 Telemetry [baseline] (9.333 ms) : 0, 9333 Telemetry [candidate] (9.197 ms) : 0, 9197 Flare Poller [baseline] (10.841 ms) : 0, 10841 Flare Poller [candidate] (11.038 ms) : 0, 11038 section appsec crashtracking [baseline] (1.461 ms) : 0, 1461 crashtracking [candidate] (1.461 ms) : 0, 1461 BytebuddyAgent [baseline] (717.049 ms) : 0, 717049 BytebuddyAgent [candidate] (718.301 ms) : 0, 718301 GlobalTracer [baseline] (234.191 ms) : 0, 234191 GlobalTracer [candidate] (234.485 ms) : 0, 234485 IAST [baseline] (24.692 ms) : 0, 24692 IAST [candidate] (24.78 ms) : 0, 24780 AppSec [baseline] (175.507 ms) : 0, 175507 AppSec [candidate] (175.236 ms) : 0, 175236 Debugger [baseline] (6.169 ms) : 0, 6169 Debugger [candidate] (6.192 ms) : 0, 6192 Remote Config [baseline] (635.729 µs) : 0, 636 Remote Config [candidate] (637.859 µs) : 0, 638 Telemetry [baseline] (8.508 ms) : 0, 8508 Telemetry [candidate] (8.494 ms) : 0, 8494 Flare Poller [baseline] (3.879 ms) : 0, 3879 Flare Poller [candidate] (3.932 ms) : 0, 3932 section iast crashtracking [baseline] (1.473 ms) : 0, 1473 crashtracking [candidate] (1.488 ms) : 0, 1488 BytebuddyAgent [baseline] (819.846 ms) : 0, 819846 BytebuddyAgent [candidate] (814.022 ms) : 0, 814022 GlobalTracer [baseline] (231.541 ms) : 0, 231541 GlobalTracer [candidate] (230.918 ms) : 0, 230918 IAST [baseline] (26.679 ms) : 0, 26679 IAST [candidate] (26.31 ms) : 0, 26310 AppSec [baseline] (35.462 ms) : 0, 35462 AppSec [candidate] (35.014 ms) : 0, 35014 Debugger [baseline] (6.211 ms) : 0, 6211 Debugger [candidate] (6.093 ms) : 0, 6093 Remote Config [baseline] (637.061 µs) : 0, 637 Remote Config [candidate] (594.962 µs) : 0, 595 Telemetry [baseline] (8.727 ms) : 0, 8727 Telemetry [candidate] (8.52 ms) : 0, 8520 Flare Poller [baseline] (4.307 ms) : 0, 4307 Flare Poller [candidate] (4.305 ms) : 0, 4305 section profiling crashtracking [baseline] (1.443 ms) : 0, 1443 crashtracking [candidate] (1.424 ms) : 0, 1424 BytebuddyAgent [baseline] (723.357 ms) : 0, 723357 BytebuddyAgent [candidate] (718.363 ms) : 0, 718363 GlobalTracer [baseline] (218.397 ms) : 0, 218397 GlobalTracer [candidate] (216.768 ms) : 0, 216768 AppSec [baseline] (32.452 ms) : 0, 32452 AppSec [candidate] (32.367 ms) : 0, 32367 Debugger [baseline] (7.203 ms) : 0, 7203 Debugger [candidate] (7.28 ms) : 0, 7280 Remote Config [baseline] (797.204 µs) : 0, 797 Remote Config [candidate] (834.914 µs) : 0, 835 Telemetry [baseline] (14.532 ms) : 0, 14532 Telemetry [candidate] (14.994 ms) : 0, 14994 Flare Poller [baseline] (4.124 ms) : 0, 4124 Flare Poller [candidate] (4.119 ms) : 0, 4119 ProfilingAgent [baseline] (107.939 ms) : 0, 107939 ProfilingAgent [candidate] (108.478 ms) : 0, 108478 Profiling [baseline] (109.191 ms) : 0, 109191 Profiling [candidate] (109.488 ms) : 0, 109488 Startup time reports for insecure-bankgantt title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~b29e71d67f, baseline=1.55.0-SNAPSHOT~d2f5bb4248 dateFormat X axisFormat %s section tracing Agent [baseline] (1.018 s) : 0, 1018318 Total [baseline] (8.642 s) : 0, 8641565 Agent [candidate] (1.013 s) : 0, 1013317 Total [candidate] (8.655 s) : 0, 8654547 section iast Agent [baseline] (1.153 s) : 0, 1153196 Total [baseline] (9.316 s) : 0, 9315695 Agent [candidate] (1.149 s) : 0, 1149311 Total [candidate] (9.266 s) : 0, 9266253
gantt title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~b29e71d67f, baseline=1.55.0-SNAPSHOT~d2f5bb4248 dateFormat X axisFormat %s section tracing crashtracking [baseline] (1.456 ms) : 0, 1456 crashtracking [candidate] (1.447 ms) : 0, 1447 BytebuddyAgent [baseline] (696.608 ms) : 0, 696608 BytebuddyAgent [candidate] (691.413 ms) : 0, 691413 GlobalTracer [baseline] (241.071 ms) : 0, 241071 GlobalTracer [candidate] (241.541 ms) : 0, 241541 AppSec [baseline] (32.317 ms) : 0, 32317 AppSec [candidate] (32.537 ms) : 0, 32537 Debugger [baseline] (6.409 ms) : 0, 6409 Debugger [candidate] (6.392 ms) : 0, 6392 Remote Config [baseline] (707.422 µs) : 0, 707 Remote Config [candidate] (704.478 µs) : 0, 704 Telemetry [baseline] (9.246 ms) : 0, 9246 Telemetry [candidate] (9.227 ms) : 0, 9227 Flare Poller [baseline] (9.446 ms) : 0, 9446 Flare Poller [candidate] (8.919 ms) : 0, 8919 section iast crashtracking [baseline] (1.49 ms) : 0, 1490 crashtracking [candidate] (1.479 ms) : 0, 1479 BytebuddyAgent [baseline] (817.365 ms) : 0, 817365 BytebuddyAgent [candidate] (814.189 ms) : 0, 814189 GlobalTracer [baseline] (231.503 ms) : 0, 231503 GlobalTracer [candidate] (231.049 ms) : 0, 231049 AppSec [baseline] (35.072 ms) : 0, 35072 AppSec [candidate] (34.823 ms) : 0, 34823 Debugger [baseline] (6.152 ms) : 0, 6152 Debugger [candidate] (6.126 ms) : 0, 6126 Remote Config [baseline] (618.777 µs) : 0, 619 Remote Config [candidate] (630.111 µs) : 0, 630 Telemetry [baseline] (8.72 ms) : 0, 8720 Telemetry [candidate] (8.731 ms) : 0, 8731 Flare Poller [baseline] (4.272 ms) : 0, 4272 Flare Poller [candidate] (4.318 ms) : 0, 4318 IAST [baseline] (26.456 ms) : 0, 26456 IAST [candidate] (26.495 ms) : 0, 26495 LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~b29e71d67f, baseline=1.55.0-SNAPSHOT~d2f5bb4248 dateFormat X axisFormat %s section baseline no_agent (37.636 ms) : 37332, 37940 . : milestone, 37636, appsec (49.472 ms) : 49034, 49910 . : milestone, 49472, code_origins (44.311 ms) : 43941, 44681 . : milestone, 44311, iast (44.453 ms) : 44075, 44831 . : milestone, 44453, profiling (48.996 ms) : 48540, 49452 . : milestone, 48996, tracing (44.635 ms) : 44247, 45024 . : milestone, 44635, section candidate no_agent (38.798 ms) : 38496, 39101 . : milestone, 38798, appsec (48.914 ms) : 48489, 49339 . : milestone, 48914, code_origins (43.996 ms) : 43628, 44364 . : milestone, 43996, iast (45.358 ms) : 44976, 45739 . : milestone, 45358, profiling (48.717 ms) : 48249, 49185 . : milestone, 48717, tracing (44.981 ms) : 44601, 45361 . : milestone, 44981,
Request duration reports for insecure-bankgantt title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~b29e71d67f, baseline=1.55.0-SNAPSHOT~d2f5bb4248 dateFormat X axisFormat %s section baseline no_agent (4.458 ms) : 4407, 4509 . : milestone, 4458, iast (10.29 ms) : 10116, 10463 . : milestone, 10290, iast_FULL (13.724 ms) : 13453, 13995 . : milestone, 13724, iast_GLOBAL (11.427 ms) : 11221, 11633 . : milestone, 11427, profiling (8.521 ms) : 8391, 8652 . : milestone, 8521, tracing (7.53 ms) : 7423, 7637 . : milestone, 7530, section candidate no_agent (4.476 ms) : 4425, 4527 . : milestone, 4476, iast (10.623 ms) : 10433, 10814 . : milestone, 10623, iast_FULL (13.721 ms) : 13447, 13996 . : milestone, 13721, iast_GLOBAL (11.191 ms) : 10991, 11391 . : milestone, 11191, profiling (8.843 ms) : 8703, 8983 . : milestone, 8843, tracing (8.382 ms) : 8260, 8503 . : milestone, 8382,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 1 unstable metrics.
Execution time for biojavagantt title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~b29e71d67f, baseline=1.55.0-SNAPSHOT~d2f5bb4248 dateFormat X axisFormat %s section baseline no_agent (14.738 s) : 14738000, 14738000 . : milestone, 14738000, appsec (15.093 s) : 15093000, 15093000 . : milestone, 15093000, iast (18.701 s) : 18701000, 18701000 . : milestone, 18701000, iast_GLOBAL (18.074 s) : 18074000, 18074000 . : milestone, 18074000, profiling (15.316 s) : 15316000, 15316000 . : milestone, 15316000, tracing (14.879 s) : 14879000, 14879000 . : milestone, 14879000, section candidate no_agent (15.034 s) : 15034000, 15034000 . : milestone, 15034000, appsec (15.019 s) : 15019000, 15019000 . : milestone, 15019000, iast (18.44 s) : 18440000, 18440000 . : milestone, 18440000, iast_GLOBAL (17.976 s) : 17976000, 17976000 . : milestone, 17976000, profiling (14.995 s) : 14995000, 14995000 . : milestone, 14995000, tracing (15.139 s) : 15139000, 15139000 . : milestone, 15139000,
Execution time for tomcatgantt title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~b29e71d67f, baseline=1.55.0-SNAPSHOT~d2f5bb4248 dateFormat X axisFormat %s section baseline no_agent (1.478 ms) : 1466, 1489 . : milestone, 1478, appsec (3.733 ms) : 3514, 3952 . : milestone, 3733, iast (2.219 ms) : 2155, 2283 . : milestone, 2219, iast_GLOBAL (2.263 ms) : 2198, 2327 . : milestone, 2263, profiling (2.478 ms) : 2248, 2707 . : milestone, 2478, tracing (2.043 ms) : 1993, 2093 . : milestone, 2043, section candidate no_agent (1.477 ms) : 1466, 1489 . : milestone, 1477, appsec (2.513 ms) : 2459, 2567 . : milestone, 2513, iast (2.204 ms) : 2140, 2268 . : milestone, 2204, iast_GLOBAL (2.255 ms) : 2190, 2319 . : milestone, 2255, profiling (2.521 ms) : 2353, 2689 . : milestone, 2521, tracing (2.04 ms) : 1989, 2090 . : milestone, 2040,
|
} | ||
generateProtoTasks { | ||
all()*.plugins { grpc {} } | ||
ofSourceSet("test").configureEach { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 good catch
What Does This Do
Proper API usage to generate the GRPC tasks
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any useful labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]