- Notifications
You must be signed in to change notification settings - Fork 314
Automatic triggering of CiVis test environment #9734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🎯 Code Coverage 🔗 Commit SHA: 529c394 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~529c394bfd, baseline=1.55.0-SNAPSHOT~ff79486cac dateFormat X axisFormat %s section tracing Agent [baseline] (1.02 s) : 0, 1019508 Total [baseline] (8.698 s) : 0, 8698359 Agent [candidate] (1.022 s) : 0, 1022372 Total [candidate] (8.674 s) : 0, 8674269 section iast Agent [baseline] (1.153 s) : 0, 1153036 Total [baseline] (9.338 s) : 0, 9337956 Agent [candidate] (1.153 s) : 0, 1153090 Total [candidate] (9.287 s) : 0, 9286946
gantt title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~529c394bfd, baseline=1.55.0-SNAPSHOT~ff79486cac dateFormat X axisFormat %s section tracing crashtracking [baseline] (1.473 ms) : 0, 1473 crashtracking [candidate] (1.463 ms) : 0, 1463 BytebuddyAgent [baseline] (694.196 ms) : 0, 694196 BytebuddyAgent [candidate] (696.832 ms) : 0, 696832 GlobalTracer [baseline] (242.034 ms) : 0, 242034 GlobalTracer [candidate] (242.806 ms) : 0, 242806 AppSec [baseline] (32.394 ms) : 0, 32394 AppSec [candidate] (32.569 ms) : 0, 32569 Debugger [baseline] (6.534 ms) : 0, 6534 Debugger [candidate] (6.44 ms) : 0, 6440 Remote Config [baseline] (734.062 µs) : 0, 734 Remote Config [candidate] (702.307 µs) : 0, 702 Telemetry [baseline] (9.294 ms) : 0, 9294 Telemetry [candidate] (9.33 ms) : 0, 9330 Flare Poller [baseline] (11.671 ms) : 0, 11671 Flare Poller [candidate] (10.912 ms) : 0, 10912 section iast crashtracking [baseline] (1.501 ms) : 0, 1501 crashtracking [candidate] (1.491 ms) : 0, 1491 BytebuddyAgent [baseline] (816.206 ms) : 0, 816206 BytebuddyAgent [candidate] (817.756 ms) : 0, 817756 GlobalTracer [baseline] (231.67 ms) : 0, 231670 GlobalTracer [candidate] (231.279 ms) : 0, 231279 AppSec [baseline] (35.298 ms) : 0, 35298 AppSec [candidate] (34.925 ms) : 0, 34925 Debugger [baseline] (6.214 ms) : 0, 6214 Debugger [candidate] (6.179 ms) : 0, 6179 Remote Config [baseline] (655.617 µs) : 0, 656 Remote Config [candidate] (608.003 µs) : 0, 608 Telemetry [baseline] (8.806 ms) : 0, 8806 Telemetry [candidate] (8.595 ms) : 0, 8595 Flare Poller [baseline] (4.245 ms) : 0, 4245 Flare Poller [candidate] (4.242 ms) : 0, 4242 IAST [baseline] (26.852 ms) : 0, 26852 IAST [candidate] (26.414 ms) : 0, 26414 Startup time reports for petclinicgantt title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~529c394bfd, baseline=1.55.0-SNAPSHOT~ff79486cac dateFormat X axisFormat %s section tracing Agent [baseline] (1.02 s) : 0, 1020006 Total [baseline] (10.687 s) : 0, 10687178 Agent [candidate] (1.017 s) : 0, 1017221 Total [candidate] (10.742 s) : 0, 10742289 section appsec Agent [baseline] (1.198 s) : 0, 1198309 Total [baseline] (11.031 s) : 0, 11031392 Agent [candidate] (1.195 s) : 0, 1194740 Total [candidate] (11.032 s) : 0, 11031831 section iast Agent [baseline] (1.15 s) : 0, 1150053 Total [baseline] (11.031 s) : 0, 11031357 Agent [candidate] (1.161 s) : 0, 1161133 Total [candidate] (11.033 s) : 0, 11032563 section profiling Agent [baseline] (1.167 s) : 0, 1167367 Total [baseline] (11.051 s) : 0, 11050834 Agent [candidate] (1.162 s) : 0, 1161585 Total [candidate] (11.072 s) : 0, 11071677
gantt title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~529c394bfd, baseline=1.55.0-SNAPSHOT~ff79486cac dateFormat X axisFormat %s section tracing crashtracking [baseline] (1.467 ms) : 0, 1467 crashtracking [candidate] (1.459 ms) : 0, 1459 BytebuddyAgent [baseline] (693.513 ms) : 0, 693513 BytebuddyAgent [candidate] (693.213 ms) : 0, 693213 GlobalTracer [baseline] (243.238 ms) : 0, 243238 GlobalTracer [candidate] (241.624 ms) : 0, 241624 AppSec [baseline] (32.233 ms) : 0, 32233 AppSec [candidate] (32.292 ms) : 0, 32292 Debugger [baseline] (6.422 ms) : 0, 6422 Debugger [candidate] (6.415 ms) : 0, 6415 Remote Config [baseline] (707.861 µs) : 0, 708 Remote Config [candidate] (708.746 µs) : 0, 709 Telemetry [baseline] (9.344 ms) : 0, 9344 Telemetry [candidate] (9.387 ms) : 0, 9387 Flare Poller [baseline] (11.948 ms) : 0, 11948 Flare Poller [candidate] (10.924 ms) : 0, 10924 section appsec crashtracking [baseline] (1.458 ms) : 0, 1458 crashtracking [candidate] (1.453 ms) : 0, 1453 BytebuddyAgent [baseline] (720.008 ms) : 0, 720008 BytebuddyAgent [candidate] (717.673 ms) : 0, 717673 GlobalTracer [baseline] (235.749 ms) : 0, 235749 GlobalTracer [candidate] (234.497 ms) : 0, 234497 AppSec [baseline] (175.737 ms) : 0, 175737 AppSec [candidate] (176.071 ms) : 0, 176071 Debugger [baseline] (6.194 ms) : 0, 6194 Debugger [candidate] (6.175 ms) : 0, 6175 Remote Config [baseline] (631.566 µs) : 0, 632 Remote Config [candidate] (628.118 µs) : 0, 628 Telemetry [baseline] (8.525 ms) : 0, 8525 Telemetry [candidate] (8.414 ms) : 0, 8414 Flare Poller [baseline] (3.928 ms) : 0, 3928 Flare Poller [candidate] (3.886 ms) : 0, 3886 IAST [baseline] (24.933 ms) : 0, 24933 IAST [candidate] (24.849 ms) : 0, 24849 section iast crashtracking [baseline] (1.467 ms) : 0, 1467 crashtracking [candidate] (1.465 ms) : 0, 1465 BytebuddyAgent [baseline] (814.255 ms) : 0, 814255 BytebuddyAgent [candidate] (823.213 ms) : 0, 823213 GlobalTracer [baseline] (231.345 ms) : 0, 231345 GlobalTracer [candidate] (232.736 ms) : 0, 232736 AppSec [baseline] (35.339 ms) : 0, 35339 AppSec [candidate] (35.379 ms) : 0, 35379 Debugger [baseline] (6.134 ms) : 0, 6134 Debugger [candidate] (6.229 ms) : 0, 6229 Remote Config [baseline] (608.737 µs) : 0, 609 Remote Config [candidate] (632.846 µs) : 0, 633 Telemetry [baseline] (8.721 ms) : 0, 8721 Telemetry [candidate] (8.667 ms) : 0, 8667 Flare Poller [baseline] (4.182 ms) : 0, 4182 Flare Poller [candidate] (4.324 ms) : 0, 4324 IAST [baseline] (26.52 ms) : 0, 26520 IAST [candidate] (26.751 ms) : 0, 26751 section profiling ProfilingAgent [baseline] (108.92 ms) : 0, 108920 ProfilingAgent [candidate] (108.441 ms) : 0, 108441 crashtracking [baseline] (1.452 ms) : 0, 1452 crashtracking [candidate] (1.433 ms) : 0, 1433 BytebuddyAgent [baseline] (724.779 ms) : 0, 724779 BytebuddyAgent [candidate] (720.67 ms) : 0, 720670 GlobalTracer [baseline] (218.559 ms) : 0, 218559 GlobalTracer [candidate] (217.786 ms) : 0, 217786 AppSec [baseline] (32.731 ms) : 0, 32731 AppSec [candidate] (32.506 ms) : 0, 32506 Debugger [baseline] (7.37 ms) : 0, 7370 Debugger [candidate] (6.456 ms) : 0, 6456 Remote Config [baseline] (792.613 µs) : 0, 793 Remote Config [candidate] (822.635 µs) : 0, 823 Telemetry [baseline] (15.202 ms) : 0, 15202 Telemetry [candidate] (16.147 ms) : 0, 16147 Flare Poller [baseline] (4.159 ms) : 0, 4159 Flare Poller [candidate] (4.208 ms) : 0, 4208 Profiling [baseline] (110.072 ms) : 0, 110072 Profiling [candidate] (109.582 ms) : 0, 109582 LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 3 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~529c394bfd, baseline=1.55.0-SNAPSHOT~ff79486cac dateFormat X axisFormat %s section baseline no_agent (4.275 ms) : 4227, 4323 . : milestone, 4275, iast (9.569 ms) : 9412, 9726 . : milestone, 9569, iast_FULL (14.175 ms) : 13896, 14454 . : milestone, 14175, iast_GLOBAL (11.074 ms) : 10875, 11273 . : milestone, 11074, profiling (9.05 ms) : 8899, 9201 . : milestone, 9050, tracing (7.81 ms) : 7697, 7923 . : milestone, 7810, section candidate no_agent (4.468 ms) : 4418, 4519 . : milestone, 4468, iast (9.38 ms) : 9226, 9533 . : milestone, 9380, iast_FULL (14.166 ms) : 13887, 14446 . : milestone, 14166, iast_GLOBAL (10.331 ms) : 10151, 10512 . : milestone, 10331, profiling (8.978 ms) : 8838, 9118 . : milestone, 8978, tracing (7.846 ms) : 7734, 7958 . : milestone, 7846,
Request duration reports for petclinicgantt title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~529c394bfd, baseline=1.55.0-SNAPSHOT~ff79486cac dateFormat X axisFormat %s section baseline no_agent (36.183 ms) : 35879, 36486 . : milestone, 36183, appsec (49.078 ms) : 48632, 49524 . : milestone, 49078, code_origins (43.671 ms) : 43295, 44047 . : milestone, 43671, iast (45.466 ms) : 45068, 45864 . : milestone, 45466, profiling (47.452 ms) : 47025, 47878 . : milestone, 47452, tracing (43.097 ms) : 42733, 43462 . : milestone, 43097, section candidate no_agent (36.672 ms) : 36382, 36962 . : milestone, 36672, appsec (48.823 ms) : 48380, 49266 . : milestone, 48823, code_origins (44.313 ms) : 43927, 44698 . : milestone, 44313, iast (42.91 ms) : 42527, 43293 . : milestone, 42910, profiling (49.701 ms) : 49247, 50155 . : milestone, 49701, tracing (45.602 ms) : 45208, 45997 . : milestone, 45602,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~529c394bfd, baseline=1.55.0-SNAPSHOT~ff79486cac dateFormat X axisFormat %s section baseline no_agent (14.909 s) : 14909000, 14909000 . : milestone, 14909000, appsec (15.035 s) : 15035000, 15035000 . : milestone, 15035000, iast (18.28 s) : 18280000, 18280000 . : milestone, 18280000, iast_GLOBAL (18.035 s) : 18035000, 18035000 . : milestone, 18035000, profiling (15.42 s) : 15420000, 15420000 . : milestone, 15420000, tracing (15.104 s) : 15104000, 15104000 . : milestone, 15104000, section candidate no_agent (14.706 s) : 14706000, 14706000 . : milestone, 14706000, appsec (14.918 s) : 14918000, 14918000 . : milestone, 14918000, iast (18.791 s) : 18791000, 18791000 . : milestone, 18791000, iast_GLOBAL (18.204 s) : 18204000, 18204000 . : milestone, 18204000, profiling (14.942 s) : 14942000, 14942000 . : milestone, 14942000, tracing (14.961 s) : 14961000, 14961000 . : milestone, 14961000,
Execution time for tomcatgantt title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~529c394bfd, baseline=1.55.0-SNAPSHOT~ff79486cac dateFormat X axisFormat %s section baseline no_agent (1.482 ms) : 1470, 1493 . : milestone, 1482, appsec (3.75 ms) : 3530, 3970 . : milestone, 3750, iast (2.225 ms) : 2161, 2289 . : milestone, 2225, iast_GLOBAL (2.278 ms) : 2213, 2343 . : milestone, 2278, profiling (2.479 ms) : 2325, 2634 . : milestone, 2479, tracing (2.043 ms) : 1992, 2093 . : milestone, 2043, section candidate no_agent (1.48 ms) : 1468, 1491 . : milestone, 1480, appsec (3.724 ms) : 3503, 3945 . : milestone, 3724, iast (2.237 ms) : 2173, 2302 . : milestone, 2237, iast_GLOBAL (2.264 ms) : 2199, 2329 . : milestone, 2264, profiling (2.064 ms) : 2011, 2116 . : milestone, 2064, tracing (2.042 ms) : 1992, 2093 . : milestone, 2042,
|
echo "Found PR #${PR_NUMBER}" | ||
# Check if PR has the CI visibility label | ||
if pr_has_label "$PR_NUMBER" "comp: ci visibility"; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❔ question: What about using run-tests:
label category?
As I will soon enforce to only have one comp:
or inst:
label to prevent duplicate changelog, I would recommend using the labels dedicated to CI task run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then we'll have to add run-tests:...
to every one of our PRs just for the sake of it. Adding comp:ci-visibility
is something we already do and won't forget to do.
I will soon enforce to only have one comp: or inst:
That's a pity, is there any other way we could avoid duplicates? E.g. if there's an instrumentation label, use it to determine the section, and then fallback to the comp one?
Test Environment - sbt-scalatestJob Status: success
|
Test Environment - nebula-release-pluginJob Status: success
|
Test Environment - pass4sJob Status: success
|
Test Environment - jolokiaJob Status: success
|
Test Environment - okhttpJob Status: success
|
What Does This Do
publish-artifacts-to-s3
finishes, the newcheck-ci-visibility-label
job queries GH API to read the PR labels.comp: ci visibility
tag, the Test Environment job is triggered.Motivation
We want to improve the Test Optimization developer workflow and more actively monitor performance regressions on our side.
Additional Notes
Current limitations:
run-ci-visibility-test-environment
job doesn't appear in the PR job list, likely because it is a trigger job. If it fails it will still fail thedefault-pipeline
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any useful labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: SDTEST-2768