- Notifications
You must be signed in to change notification settings - Fork 314
Fix environment unit tests related to IBM / J9 #9133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
AlexeyKuznetsov-DD approved these changes Jul 9, 2025
sarahchen6 approved these changes Jul 9, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~8da64b39d8, baseline=1.51.0-SNAPSHOT~a611e0c412 dateFormat X axisFormat %s section tracing Agent [baseline] (998.617 ms) : 0, 998617 Total [baseline] (8.566 s) : 0, 8566347 Agent [candidate] (996.075 ms) : 0, 996075 Total [candidate] (8.551 s) : 0, 8551459 section iast Agent [baseline] (1.13 s) : 0, 1130215 Total [baseline] (9.286 s) : 0, 9285888 Agent [candidate] (1.146 s) : 0, 1146280 Total [candidate] (9.29 s) : 0, 9289799
gantt title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~8da64b39d8, baseline=1.51.0-SNAPSHOT~a611e0c412 dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (690.877 ms) : 0, 690877 BytebuddyAgent [candidate] (687.996 ms) : 0, 687996 GlobalTracer [baseline] (241.79 ms) : 0, 241790 GlobalTracer [candidate] (242.088 ms) : 0, 242088 AppSec [baseline] (30.242 ms) : 0, 30242 AppSec [candidate] (30.325 ms) : 0, 30325 Debugger [baseline] (6.013 ms) : 0, 6013 Debugger [candidate] (6.041 ms) : 0, 6041 Remote Config [baseline] (670.008 µs) : 0, 670 Remote Config [candidate] (683.042 µs) : 0, 683 Telemetry [baseline] (8.242 ms) : 0, 8242 Telemetry [candidate] (8.209 ms) : 0, 8209 section iast BytebuddyAgent [baseline] (806.754 ms) : 0, 806754 BytebuddyAgent [candidate] (818.295 ms) : 0, 818295 GlobalTracer [baseline] (231.529 ms) : 0, 231529 GlobalTracer [candidate] (234.341 ms) : 0, 234341 AppSec [baseline] (29.375 ms) : 0, 29375 AppSec [candidate] (30.148 ms) : 0, 30148 Debugger [baseline] (5.704 ms) : 0, 5704 Debugger [candidate] (6.771 ms) : 0, 6771 Remote Config [baseline] (573.149 µs) : 0, 573 Remote Config [candidate] (582.74 µs) : 0, 583 Telemetry [baseline] (7.921 ms) : 0, 7921 Telemetry [candidate] (7.949 ms) : 0, 7949 IAST [baseline] (27.684 ms) : 0, 27684 IAST [candidate] (27.346 ms) : 0, 27346 Startup time reports for petclinicgantt title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~8da64b39d8, baseline=1.51.0-SNAPSHOT~a611e0c412 dateFormat X axisFormat %s section tracing Agent [baseline] (994.585 ms) : 0, 994585 Total [baseline] (10.663 s) : 0, 10662527 Agent [candidate] (996.621 ms) : 0, 996621 Total [candidate] (10.655 s) : 0, 10654552 section appsec Agent [baseline] (1.177 s) : 0, 1176577 Total [baseline] (10.738 s) : 0, 10738207 Agent [candidate] (1.182 s) : 0, 1182482 Total [candidate] (10.804 s) : 0, 10803949 section iast Agent [baseline] (1.131 s) : 0, 1131046 Total [baseline] (10.801 s) : 0, 10800745 Agent [candidate] (1.141 s) : 0, 1140821 Total [candidate] (10.809 s) : 0, 10809023 section profiling Agent [baseline] (1.245 s) : 0, 1245047 Total [baseline] (10.967 s) : 0, 10967362 Agent [candidate] (1.25 s) : 0, 1249643 Total [candidate] (11.002 s) : 0, 11002007
gantt title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~8da64b39d8, baseline=1.51.0-SNAPSHOT~a611e0c412 dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (687.131 ms) : 0, 687131 BytebuddyAgent [candidate] (687.693 ms) : 0, 687693 GlobalTracer [baseline] (241.615 ms) : 0, 241615 GlobalTracer [candidate] (242.763 ms) : 0, 242763 AppSec [baseline] (30.166 ms) : 0, 30166 AppSec [candidate] (30.453 ms) : 0, 30453 Debugger [baseline] (5.974 ms) : 0, 5974 Debugger [candidate] (6.049 ms) : 0, 6049 Remote Config [baseline] (671.576 µs) : 0, 672 Remote Config [candidate] (681.771 µs) : 0, 682 Telemetry [baseline] (8.225 ms) : 0, 8225 Telemetry [candidate] (8.241 ms) : 0, 8241 section appsec BytebuddyAgent [baseline] (711.46 ms) : 0, 711460 BytebuddyAgent [candidate] (715.653 ms) : 0, 715653 GlobalTracer [baseline] (235.47 ms) : 0, 235470 GlobalTracer [candidate] (236.553 ms) : 0, 236553 AppSec [baseline] (171.024 ms) : 0, 171024 AppSec [candidate] (171.284 ms) : 0, 171284 Debugger [baseline] (5.704 ms) : 0, 5704 Debugger [candidate] (5.787 ms) : 0, 5787 Remote Config [baseline] (594.224 µs) : 0, 594 Remote Config [candidate] (592.278 µs) : 0, 592 Telemetry [baseline] (8.055 ms) : 0, 8055 Telemetry [candidate] (8.127 ms) : 0, 8127 IAST [baseline] (23.342 ms) : 0, 23342 IAST [candidate] (23.527 ms) : 0, 23527 section iast BytebuddyAgent [baseline] (806.307 ms) : 0, 806307 BytebuddyAgent [candidate] (813.96 ms) : 0, 813960 GlobalTracer [baseline] (231.985 ms) : 0, 231985 GlobalTracer [candidate] (233.562 ms) : 0, 233562 AppSec [baseline] (29.789 ms) : 0, 29789 AppSec [candidate] (29.195 ms) : 0, 29195 Debugger [baseline] (5.726 ms) : 0, 5726 Debugger [candidate] (5.869 ms) : 0, 5869 Remote Config [baseline] (581.662 µs) : 0, 582 Remote Config [candidate] (582.598 µs) : 0, 583 Telemetry [baseline] (7.944 ms) : 0, 7944 Telemetry [candidate] (7.987 ms) : 0, 7987 IAST [baseline] (27.977 ms) : 0, 27977 IAST [candidate] (28.828 ms) : 0, 28828 section profiling BytebuddyAgent [baseline] (677.565 ms) : 0, 677565 BytebuddyAgent [candidate] (680.688 ms) : 0, 680688 GlobalTracer [baseline] (361.626 ms) : 0, 361626 GlobalTracer [candidate] (362.867 ms) : 0, 362867 AppSec [baseline] (33.158 ms) : 0, 33158 AppSec [candidate] (32.394 ms) : 0, 32394 Debugger [baseline] (9.146 ms) : 0, 9146 Debugger [candidate] (11.957 ms) : 0, 11957 Remote Config [baseline] (663.134 µs) : 0, 663 Remote Config [candidate] (656.322 µs) : 0, 656 Telemetry [baseline] (10.233 ms) : 0, 10233 Telemetry [candidate] (8.09 ms) : 0, 8090 ProfilingAgent [baseline] (104.112 ms) : 0, 104112 ProfilingAgent [candidate] (104.526 ms) : 0, 104526 Profiling [baseline] (104.136 ms) : 0, 104136 Profiling [candidate] (104.55 ms) : 0, 104550 LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~8da64b39d8, baseline=1.51.0-SNAPSHOT~a611e0c412 dateFormat X axisFormat %s section baseline no_agent (36.319 ms) : 36023, 36614 . : milestone, 36319, appsec (47.243 ms) : 46837, 47648 . : milestone, 47243, code_origins (45.166 ms) : 44775, 45556 . : milestone, 45166, iast (44.612 ms) : 44225, 44998 . : milestone, 44612, profiling (48.413 ms) : 47976, 48850 . : milestone, 48413, tracing (44.708 ms) : 44325, 45091 . : milestone, 44708, section candidate no_agent (36.39 ms) : 36103, 36677 . : milestone, 36390, appsec (46.97 ms) : 46565, 47375 . : milestone, 46970, code_origins (44.731 ms) : 44337, 45124 . : milestone, 44731, iast (44.029 ms) : 43645, 44413 . : milestone, 44029, profiling (48.434 ms) : 47983, 48885 . : milestone, 48434, tracing (44.304 ms) : 43945, 44662 . : milestone, 44304,
Request duration reports for insecure-bankgantt title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~8da64b39d8, baseline=1.51.0-SNAPSHOT~a611e0c412 dateFormat X axisFormat %s section baseline no_agent (4.477 ms) : 4427, 4528 . : milestone, 4477, iast (9.375 ms) : 9223, 9528 . : milestone, 9375, iast_FULL (13.579 ms) : 13315, 13843 . : milestone, 13579, iast_GLOBAL (10.086 ms) : 9897, 10275 . : milestone, 10086, profiling (9.215 ms) : 9059, 9370 . : milestone, 9215, tracing (8.048 ms) : 7931, 8165 . : milestone, 8048, section candidate no_agent (4.396 ms) : 4347, 4446 . : milestone, 4396, iast (9.159 ms) : 9015, 9304 . : milestone, 9159, iast_FULL (13.733 ms) : 13459, 14006 . : milestone, 13733, iast_GLOBAL (10.609 ms) : 10422, 10796 . : milestone, 10609, profiling (8.226 ms) : 8104, 8348 . : milestone, 8226, tracing (7.376 ms) : 7268, 7485 . : milestone, 7376,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~8da64b39d8, baseline=1.51.0-SNAPSHOT~a611e0c412 dateFormat X axisFormat %s section baseline no_agent (1.484 ms) : 1473, 1496 . : milestone, 1484, appsec (2.426 ms) : 2376, 2476 . : milestone, 2426, iast (2.213 ms) : 2150, 2275 . : milestone, 2213, iast_GLOBAL (2.26 ms) : 2197, 2323 . : milestone, 2260, profiling (2.502 ms) : 2275, 2728 . : milestone, 2502, tracing (2.016 ms) : 1968, 2064 . : milestone, 2016, section candidate no_agent (1.49 ms) : 1478, 1501 . : milestone, 1490, appsec (2.425 ms) : 2375, 2475 . : milestone, 2425, iast (2.209 ms) : 2146, 2272 . : milestone, 2209, iast_GLOBAL (2.254 ms) : 2192, 2317 . : milestone, 2254, profiling (2.065 ms) : 2014, 2117 . : milestone, 2065, tracing (2.024 ms) : 1976, 2073 . : milestone, 2024,
Execution time for biojavagantt title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~8da64b39d8, baseline=1.51.0-SNAPSHOT~a611e0c412 dateFormat X axisFormat %s section baseline no_agent (15.46 s) : 15460000, 15460000 . : milestone, 15460000, appsec (15.128 s) : 15128000, 15128000 . : milestone, 15128000, iast (17.965 s) : 17965000, 17965000 . : milestone, 17965000, iast_GLOBAL (18.149 s) : 18149000, 18149000 . : milestone, 18149000, profiling (15.203 s) : 15203000, 15203000 . : milestone, 15203000, tracing (14.905 s) : 14905000, 14905000 . : milestone, 14905000, section candidate no_agent (15.508 s) : 15508000, 15508000 . : milestone, 15508000, appsec (14.904 s) : 14904000, 14904000 . : milestone, 14904000, iast (18.621 s) : 18621000, 18621000 . : milestone, 18621000, iast_GLOBAL (17.708 s) : 17708000, 17708000 . : milestone, 17708000, profiling (15.756 s) : 15756000, 15756000 . : milestone, 15756000, tracing (14.783 s) : 14783000, 14783000 . : milestone, 14783000,
|
bric3 approved these changes Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: platform Platform components tag: no release notes Changes to exclude from release notes type: bug Bug report and fix
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR fixes environment unit tests related to IBM / J9
Motivation
Additional Notes
I missed those tests as they aren't running on PR check
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]